Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Alexander Graf
Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions and move the functionality into a separate file under hw/. Phew. I'm not sure this is a great idea. At least not the

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Christian Borntraeger
On 12/06/12 11:58, Alexander Graf wrote: Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions and move the functionality into a separate file under hw/. Phew. I'm not

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Alexander Graf
On 12.06.2012, at 12:07, Christian Borntraeger borntrae...@de.ibm.com wrote: On 12/06/12 11:58, Alexander Graf wrote: Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Alexander Graf
On 12.06.2012, at 12:07, Christian Borntraeger borntrae...@de.ibm.com wrote: On 12/06/12 11:58, Alexander Graf wrote: Jens Freimann wrote: From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Christian Borntraeger
Yes we will re-split the sclp patches. besides that, some comments: On 12/06/12 11:58, Alexander Graf wrote: +#include hw/s390-sclp.h No need for hw/. will fix. +void sclp_service_interrupt(CPUS390XState *env, uint32_t sccb) +{ +if (!sccb) { +return; +} + +

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Alexander Graf
On 06/12/2012 02:24 PM, Christian Borntraeger wrote: Yes we will re-split the sclp patches. besides that, some comments: On 12/06/12 11:58, Alexander Graf wrote: +#include hw/s390-sclp.h No need for hw/. will fix. +void sclp_service_interrupt(CPUS390XState *env, uint32_t sccb) +{ +

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Anthony Liguori
On 06/06/2012 07:05 AM, Jens Freimann wrote: From: Christian Borntraegerborntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions and move the functionality into a separate file under hw/. Signed-off-by: Christian

Re: [Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-12 Thread Anthony Liguori
On 06/12/2012 07:32 AM, Alexander Graf wrote: On 06/12/2012 02:24 PM, Christian Borntraeger wrote: Yes we will re-split the sclp patches. besides that, some comments: On 12/06/12 11:58, Alexander Graf wrote: +#include hw/s390-sclp.h No need for hw/. will fix. +void

[Qemu-devel] [PATCH 5/8] s390: Cleanup sclp functions

2012-06-06 Thread Jens Freimann
From: Christian Borntraeger borntrae...@de.ibm.com The sclp facility on s390 is a hardware that is external to the cpu. Lets cleanup the definitions and move the functionality into a separate file under hw/. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Jens Freimann