Re: [Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure

2012-07-10 Thread Paolo Bonzini
Il 09/07/2012 21:17, miny...@acm.org ha scritto: From: Corey Minyard cminy...@mvista.com This provides the base infrastructure to tie IPMI low-level interfaces into a PC ISA bus. Signed-off-by: Corey Minyard cminy...@mvista.com --- default-configs/i386-softmmu.mak |1 +

Re: [Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure

2012-07-10 Thread Paolo Bonzini
Il 09/07/2012 21:17, miny...@acm.org ha scritto: + +static Property ipmi_isa_properties[] = { +DEFINE_PROP_HEX32(type, ISAIPMIState, type, IPMI_KCS), You can add an enum property. There is one example called LostTickPolicy in the tree. Please do not use the generic type name; use

Re: [Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure

2012-07-10 Thread Corey Minyard
On 07/10/2012 04:33 AM, Paolo Bonzini wrote: Here, you should add a normal chardev property so that people can use -chardev and -device to create the IPMI interface. The device can be created like this: -chardev ...,id=charipmi -device ipmi,interface=kcs,chardev=charipmi If the chardev is

[Qemu-devel] [PATCH 5/9] IPMI: Add a PC ISA type structure

2012-07-09 Thread minyard
From: Corey Minyard cminy...@mvista.com This provides the base infrastructure to tie IPMI low-level interfaces into a PC ISA bus. Signed-off-by: Corey Minyard cminy...@mvista.com --- default-configs/i386-softmmu.mak |1 + default-configs/x86_64-softmmu.mak |1 + hw/Makefile.objs