Re: [Qemu-devel] [PATCH 54/54] block: Add Error parameter to bdrv_append()

2017-02-25 Thread Max Reitz
On 21.02.2017 15:58, Kevin Wolf wrote: > Aborting on error in bdrv_append() isn't correct. This patch fixes it > and lets the callers handle failures. > > Test case 085 needs a reference output update. This is caused by the > reversed order of bdrv_set_backing_hd() and

[Qemu-devel] [PATCH 54/54] block: Add Error parameter to bdrv_append()

2017-02-21 Thread Kevin Wolf
Aborting on error in bdrv_append() isn't correct. This patch fixes it and lets the callers handle failures. Test case 085 needs a reference output update. This is caused by the reversed order of bdrv_set_backing_hd() and change_parent_backing_link() in bdrv_append(): When the backing file of the