Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-28 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Juan Quintela (quint...@redhat.com) wrote: > >> This way we use the "normal" way of printing errors for hmp commands. > >> > >> -- > >> Paolo suggestion > >> > >> Signed-off-by: Juan

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-28 Thread Eric Blake
On 04/28/2017 09:47 AM, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> This way we use the "normal" way of printing errors for hmp commands. >> >> -- >> if (!bdrv_all_can_snapshot()) { >> -error_report("Device '%s' is writable but does not support >>

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-28 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Juan Quintela (quint...@redhat.com) wrote: >> This way we use the "normal" way of printing errors for hmp commands. >> >> -- >> Paolo suggestion >> >> Signed-off-by: Juan Quintela > > > >> +int save_vmstate(const

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-28 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > This way we use the "normal" way of printing errors for hmp commands. > > -- > Paolo suggestion > > Signed-off-by: Juan Quintela > +int save_vmstate(const char *name, Error **errp) > { > BlockDriverState *bs, *bs1; >

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Juan Quintela
Laurent Vivier wrote: > On 25/04/2017 19:00, Juan Quintela wrote: >> Laurent Vivier wrote: >>> On 25/04/2017 12:24, Juan Quintela wrote: { +Error *err = NULL; + if (replay_snapshot) { if (replay_mode ==

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Laurent Vivier
On 25/04/2017 19:00, Juan Quintela wrote: > Laurent Vivier wrote: >> On 25/04/2017 12:24, Juan Quintela wrote: >>> This way we use the "normal" way of printing errors for hmp commands. >>> >>> -- >>> Paolo suggestion >> >> "Suggested-by" tag? > > Thanks. >>> { >>> +Error

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Juan Quintela
Laurent Vivier wrote: > On 25/04/2017 12:24, Juan Quintela wrote: >> This way we use the "normal" way of printing errors for hmp commands. >> >> -- >> Paolo suggestion > > "Suggested-by" tag? Thanks. >> { >> +Error *err = NULL; >> + >> if (replay_snapshot) { >>

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Laurent Vivier
On 25/04/2017 12:24, Juan Quintela wrote: > This way we use the "normal" way of printing errors for hmp commands. > > -- > Paolo suggestion "Suggested-by" tag? > > Signed-off-by: Juan Quintela > --- > hmp.c| 9 +++-- > include/sysemu/sysemu.h |

[Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Juan Quintela
This way we use the "normal" way of printing errors for hmp commands. -- Paolo suggestion Signed-off-by: Juan Quintela --- hmp.c| 9 +++-- include/sysemu/sysemu.h | 4 ++-- migration/savevm.c | 51