On 12.01.2010, at 19:33, Michael S. Tsirkin wrote:
Guys, I was wondering whether the following helper function will be
helpful, as a lot of common code seems to be around identical b/w/l
callbacks. Comments?
I like the idea. That could potentially clean up quite a bit of code in qemu.
Alex
Move out pci address decoding logic from pci_data_{write, read}()
by making pci_data_{write, read}() get PCIConfigAddress.
Cc: Blue Swirl blauwir...@gmail.com
Cc: Aurelien Jarno aurel...@aurel32.net
Cc: Paul Brook p...@codesourcery.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Isaku Yamahata wrote:
Move out pci address decoding logic from pci_data_{write, read}()
by making pci_data_{write, read}() get PCIConfigAddress.
I think this is going in the wrong direction. You are keeping the device
specific MMIO/PIO based config space access handlers and just move the
Guys, I was wondering whether the following helper function will be
helpful, as a lot of common code seems to be around identical b/w/l
callbacks. Comments?
diff --git a/cpu-common.h b/cpu-common.h
index 0ec9b72..be7e992 100644
--- a/cpu-common.h
+++ b/cpu-common.h
@@ -42,6 +42,24 @@ int
