Re: [Qemu-devel] [PATCH 6/9] ioport: split deletion and destruction

2014-07-31 Thread Paolo Bonzini
Il 31/07/2014 14:34, Peter Crosthwaite ha scritto: > So I found the original implementation made sense to me, in that _del > is the converse of _add and _destroy _init WRT to the MR ops. > > Currently > _init = malloc array > _add = mr_init + mr_add_subregion > _del = mr_del_subregion + mr_destroy

Re: [Qemu-devel] [PATCH 6/9] ioport: split deletion and destruction

2014-07-31 Thread Peter Crosthwaite
On Wed, Jul 30, 2014 at 8:27 PM, Paolo Bonzini wrote: > Of the two functions portio_list_del and portio_list_destroy, > the latter is just freeing a memory area. However, portio_list_del > is the logical equivalent of memory_region_del_subregion so > destruction of memory regions does not belong

[Qemu-devel] [PATCH 6/9] ioport: split deletion and destruction

2014-07-30 Thread Paolo Bonzini
Of the two functions portio_list_del and portio_list_destroy, the latter is just freeing a memory area. However, portio_list_del is the logical equivalent of memory_region_del_subregion so destruction of memory regions does not belong there. Signed-off-by: Paolo Bonzini --- ioport.c | 11 ++