Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-27 Thread Markus Armbruster
Eric Blake writes: > On 07/21/2017 08:53 AM, Markus Armbruster wrote: >> Leaving interpolation into JSON to qmp() is more robust than building >> QMP input manually, as explained in the commit before previous. >> >> The case in qpci_plug_device_test() is a bit complicated: it

Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-25 Thread Eric Blake
On 07/21/2017 08:53 AM, Markus Armbruster wrote: > Leaving interpolation into JSON to qmp() is more robust than building > QMP input manually, as explained in the commit before previous. > > The case in qpci_plug_device_test() is a bit complicated: it > interpolates several JSON object members,

Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-25 Thread Stefan Hajnoczi
On Fri, Jul 21, 2017 at 03:53:23PM +0200, Markus Armbruster wrote: > Leaving interpolation into JSON to qmp() is more robust than building > QMP input manually, as explained in the commit before previous. > > The case in qpci_plug_device_test() is a bit complicated: it > interpolates several JSON

Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-21 Thread Markus Armbruster
Eric Blake writes: > On 07/21/2017 08:53 AM, Markus Armbruster wrote: >> Leaving interpolation into JSON to qmp() is more robust than building >> QMP input manually, as explained in the commit before previous. >> >> The case in qpci_plug_device_test() is a bit complicated: it

Re: [Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-21 Thread Eric Blake
On 07/21/2017 08:53 AM, Markus Armbruster wrote: > Leaving interpolation into JSON to qmp() is more robust than building > QMP input manually, as explained in the commit before previous. > > The case in qpci_plug_device_test() is a bit complicated: it > interpolates several JSON object members,

[Qemu-devel] [PATCH 6/9] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-21 Thread Markus Armbruster
Leaving interpolation into JSON to qmp() is more robust than building QMP input manually, as explained in the commit before previous. The case in qpci_plug_device_test() is a bit complicated: it interpolates several JSON object members, not just a value. Clean it up by passing them in as QDict