Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Igor Mammedov
On Mon, 29 Jul 2013 15:41:57 -0400 Jason J. Herne jjhe...@linux.vnet.ibm.com wrote: On 06/08/2013 09:11 PM, Andreas Färber wrote: if (tcg_enabled() !inited) { inited = true; s390x_translate_init(); } + +smp_cpus += 1; Won't we need some form of

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Igor Mammedov
On Sun, 09 Jun 2013 03:11:35 +0200 Andreas Färber afaer...@suse.de wrote: Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Modify cpu initialization and QOM routines associated with s390-cpu such that all cpus on S390 are now created via the QOM

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Jason J. Herne
On 07/30/2013 03:24 AM, Igor Mammedov wrote: On Mon, 29 Jul 2013 15:41:57 -0400 Jason J. Herne jjhe...@linux.vnet.ibm.com wrote: On 06/08/2013 09:11 PM, Andreas Färber wrote: if (tcg_enabled() !inited) { inited = true; s390x_translate_init(); } + +smp_cpus

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Igor Mammedov
On Tue, 30 Jul 2013 10:27:26 -0400 Jason J. Herne jjhe...@linux.vnet.ibm.com wrote: On 07/30/2013 03:24 AM, Igor Mammedov wrote: On Mon, 29 Jul 2013 15:41:57 -0400 Jason J. Herne jjhe...@linux.vnet.ibm.com wrote: On 06/08/2013 09:11 PM, Andreas Färber wrote: if (tcg_enabled()

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-30 Thread Andreas Färber
Am 30.07.2013 16:50, schrieb Igor Mammedov: On Tue, 30 Jul 2013 10:27:26 -0400 Jason J. Herne jjhe...@linux.vnet.ibm.com wrote: On 07/30/2013 03:24 AM, Igor Mammedov wrote: Is there an easier way of getting the count besides this? int cpu_count = 0; for (cpu = first_cpu; cpu != NULL; cpu =

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-07-29 Thread Jason J. Herne
On 06/08/2013 09:11 PM, Andreas Färber wrote: if (tcg_enabled() !inited) { inited = true; s390x_translate_init(); } + +smp_cpus += 1; Won't we need some form of locking? If we fiddle with a global CPU counter, we should do so in qom/cpu.c, not just in s390x

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-06-10 Thread Cornelia Huck
On Sun, 09 Jun 2013 03:11:35 +0200 Andreas Färber afaer...@suse.de wrote: Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Modify cpu initialization and QOM routines associated with s390-cpu such that all cpus on S390 are now created via the QOM

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-06-10 Thread Jason J. Herne
On 06/08/2013 09:11 PM, Andreas Färber wrote: Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Modify cpu initialization and QOM routines associated with s390-cpu such that all cpus on S390 are now created via the QOM device creation code path.

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-06-08 Thread Andreas Färber
Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Modify cpu initialization and QOM routines associated with s390-cpu such that all cpus on S390 are now created via the QOM device creation code path. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com ---

[Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-06-07 Thread Jason J. Herne
From: Jason J. Herne jjhe...@us.ibm.com Modify cpu initialization and QOM routines associated with s390-cpu such that all cpus on S390 are now created via the QOM device creation code path. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c | 15 ++-