Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-08-19 Thread Luiz Capitulino
On Mon, 22 Jul 2013 23:07:36 +0200 Laszlo Ersek ler...@redhat.com wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com This patch now conflicts, can you respin please? --- tests/Makefile|6 +- qapi-schema-test.json | 15 +++ tests/test-opts-visitor.c | 275

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-08-19 Thread Laszlo Ersek
On 08/19/13 21:26, Luiz Capitulino wrote: On Mon, 22 Jul 2013 23:07:36 +0200 Laszlo Ersek ler...@redhat.com wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com This patch now conflicts, can you respin please? Can you retry with git am -3? git rebase -i didn't ask me to do anything

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-08-19 Thread Laszlo Ersek
On 08/19/13 21:55, Laszlo Ersek wrote: On 08/19/13 21:26, Luiz Capitulino wrote: On Mon, 22 Jul 2013 23:07:36 +0200 Laszlo Ersek ler...@redhat.com wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com This patch now conflicts, can you respin please? Can you retry with git am -3? git

[Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Laszlo Ersek
Signed-off-by: Laszlo Ersek ler...@redhat.com --- tests/Makefile|6 +- qapi-schema-test.json | 15 +++ tests/test-opts-visitor.c | 275 + .gitignore|1 + 4 files changed, 296 insertions(+), 1 deletions(-)

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Eric Blake
On 07/22/2013 03:07 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- tests/Makefile|6 +- qapi-schema-test.json | 15 +++ tests/test-opts-visitor.c | 275 + .gitignore|1 + 4

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Eric Blake
On 07/22/2013 04:24 PM, Laszlo Ersek wrote: Pretty thorough, although I thought of a couple other ideas to test: i64=5z-6 should fail; i64=5-6-7 should fail I can add them if you insist, but I wrote (and single-stepped all of) the test cases so that all branches added by patches 3, 5 and 6

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Laszlo Ersek
On 07/23/13 00:04, Eric Blake wrote: On 07/22/2013 03:07 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- tests/Makefile|6 +- qapi-schema-test.json | 15 +++ tests/test-opts-visitor.c | 275 +

Re: [Qemu-devel] [PATCH 8/8] OptsVisitor: introduce unit tests, with test cases for range flattening

2013-07-22 Thread Laszlo Ersek
On 07/23/13 00:26, Eric Blake wrote: On 07/22/2013 04:24 PM, Laszlo Ersek wrote: Pretty thorough, although I thought of a couple other ideas to test: i64=5z-6 should fail; i64=5-6-7 should fail I can add them if you insist, but I wrote (and single-stepped all of) the test cases so that all