Re: [Qemu-devel] [PATCH 8/9] virt_arm: acpi: reuse common build_fadt()

2018-02-27 Thread Igor Mammedov
On Tue, 27 Feb 2018 16:07:49 +0100 Auger Eric wrote: > Hi Igor, > On 22/02/18 13:42, Igor Mammedov wrote: > > Extend generic build_fadt() to support rev5.1 FADT > > and reuse it for 'virt' board, it would allow to > > phase out usage of AcpiFadtDescriptorRev5_1 and > >

Re: [Qemu-devel] [PATCH 8/9] virt_arm: acpi: reuse common build_fadt()

2018-02-27 Thread Auger Eric
Hi Igor, On 22/02/18 13:42, Igor Mammedov wrote: > Extend generic build_fadt() to support rev5.1 FADT > and reuse it for 'virt' board, it would allow to > phase out usage of AcpiFadtDescriptorRev5_1 and > later ACPI_FADT_COMMON_DEF. Oups sorry sent the R-b to fast. Some small comments below. > >

Re: [Qemu-devel] [PATCH 8/9] virt_arm: acpi: reuse common build_fadt()

2018-02-27 Thread Auger Eric
On 22/02/18 13:42, Igor Mammedov wrote: > Extend generic build_fadt() to support rev5.1 FADT > and reuse it for 'virt' board, it would allow to > phase out usage of AcpiFadtDescriptorRev5_1 and > later ACPI_FADT_COMMON_DEF. > > Signed-off-by: Igor Mammedov Reviewed-by:

[Qemu-devel] [PATCH 8/9] virt_arm: acpi: reuse common build_fadt()

2018-02-22 Thread Igor Mammedov
Extend generic build_fadt() to support rev5.1 FADT and reuse it for 'virt' board, it would allow to phase out usage of AcpiFadtDescriptorRev5_1 and later ACPI_FADT_COMMON_DEF. Signed-off-by: Igor Mammedov --- include/hw/acpi/acpi-defs.h | 12 ++--