[Qemu-devel] [PATCH 9/9] usb: mtp: reply INCOMPLETE_TRANSFER on read errors

2014-04-25 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 6bd6a82..8e1a1b7 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -50,6 +50,7 @@ enum mtp_code {

Re: [Qemu-devel] [PATCH 9/9] usb: mtp: reply INCOMPLETE_TRANSFER on read errors

2014-04-25 Thread Peter Wu
On Friday 25 April 2014 12:48:14 Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-mtp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 6bd6a82..8e1a1b7 100644 --- a/hw/usb/dev-mtp.c +++

Re: [Qemu-devel] [PATCH 9/9] usb: mtp: reply INCOMPLETE_TRANSFER on read errors

2014-04-25 Thread Gerd Hoffmann
Hi, The bogus data packet is sent with usb_packet_copy, shouldn't you return USB_RET_NAK for now? I don't think so. The transfer must be completed, even if we don't send valid data, because the guest expects a certain number of data bytes before the result packet with the status code. If