Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-16 Thread Amos Kong
On Mon, Jul 15, 2013 at 09:28:28PM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 11, 2013 at 10:28:15PM +0800, Amos Kong wrote: > > Markus added some comments on old patchset, this patch contains > > some additional fixes, it's based on MST's PCI tree. > > > > * Fix typos (missed 1.6, NIC) > > *

Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-15 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 10:28:15PM +0800, Amos Kong wrote: > Markus added some comments on old patchset, this patch contains > some additional fixes, it's based on MST's PCI tree. > > * Fix typos (missed 1.6, NIC) > * Don't initialize list point at its declaration > * Always notify QMP client if m

Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-15 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Jul 11, 2013 at 12:52:56PM -0600, Eric Blake wrote: >> On 07/11/2013 08:28 AM, Amos Kong wrote: >> > Markus added some comments on old patchset, this patch contains >> > some additional fixes, it's based on MST's PCI tree. >> > >> > * Fix typos (missed 1.6,

Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-15 Thread Markus Armbruster
Amos Kong writes: > Markus added some comments on old patchset, this patch contains > some additional fixes, it's based on MST's PCI tree. > > * Fix typos (missed 1.6, NIC) > * Don't initialize list point at its declaration > * Always notify QMP client if mactable is changed > * Returns NULL list

Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-11 Thread Michael S. Tsirkin
On Thu, Jul 11, 2013 at 12:52:56PM -0600, Eric Blake wrote: > On 07/11/2013 08:28 AM, Amos Kong wrote: > > Markus added some comments on old patchset, this patch contains > > some additional fixes, it's based on MST's PCI tree. > > > > * Fix typos (missed 1.6, NIC) > > * Don't initialize list poin

Re: [Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-11 Thread Eric Blake
On 07/11/2013 08:28 AM, Amos Kong wrote: > Markus added some comments on old patchset, this patch contains > some additional fixes, it's based on MST's PCI tree. > > * Fix typos (missed 1.6, NIC) > * Don't initialize list point at its declaration > * Always notify QMP client if mactable is changed

[Qemu-devel] [PATCH MST/PCI] additional fixes for mac-programming feature

2013-07-11 Thread Amos Kong
Markus added some comments on old patchset, this patch contains some additional fixes, it's based on MST's PCI tree. * Fix typos (missed 1.6, NIC) * Don't initialize list point at its declaration * Always notify QMP client if mactable is changed * Returns NULL list if no net client supports rx-fil