Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 15:28, Andreas Färber ha scritto: >>> However I don't see in the curent Makefile.target and rules.mak where >>> the *.d files are being included today >> >> Makefile.target also includes Makefile.objs and calls the unnesting >> machinery in rules.mak. The machinery then includes the

Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-02-21 Thread Andreas Färber
Am 21.02.2013 14:19, schrieb Paolo Bonzini: > Il 21/02/2013 13:52, Andreas Färber ha scritto: >> As discussed on IRC, what happened here it seems is that at the time of >> writing the patch (two releases ago) we had -include *.d in >> Makefile.target, so the generated .mak.d files were effectively

Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 13:52, Andreas Färber ha scritto: > As discussed on IRC, what happened here it seems is that at the time of > writing the patch (two releases ago) we had -include *.d in > Makefile.target, so the generated .mak.d files were effectively included > from two Makefiles, working for one bu

Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-02-21 Thread Andreas Färber
Am 21.02.2013 13:34, schrieb Peter Maydell: > On 24 January 2013 15:47, Andreas Färber wrote: >> config-devices.mak.d is included from Makefile.target, i.e. from inside >> the *-softmmu/ directory. It included the directory path, so never >> applied to the actual ./config-devices.mak. Symptoms wer

Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-02-21 Thread Peter Maydell
On 24 January 2013 15:47, Andreas Färber wrote: > config-devices.mak.d is included from Makefile.target, i.e. from inside > the *-softmmu/ directory. It included the directory path, so never > applied to the actual ./config-devices.mak. Symptoms were spurious > build failures due to missing depend

Re: [Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-01-26 Thread Blue Swirl
Thanks, applied. On Thu, Jan 24, 2013 at 3:47 PM, Andreas Färber wrote: > config-devices.mak.d is included from Makefile.target, i.e. from inside > the *-softmmu/ directory. It included the directory path, so never > applied to the actual ./config-devices.mak. Symptoms were spurious > build failu

[Qemu-devel] [PATCH RESEND for-1.4] make_device_config.sh: Fix target path in generated dependency file

2013-01-24 Thread Andreas Färber
config-devices.mak.d is included from Makefile.target, i.e. from inside the *-softmmu/ directory. It included the directory path, so never applied to the actual ./config-devices.mak. Symptoms were spurious build failures due to missing dependency on default-configs/pci.mak. Fix this by using `base