Re: [Qemu-devel] [PATCH RFC] target-ppc: Correctly handle translation address when bus unit ID = 0x07F

2011-06-14 Thread Alexander Graf
On 14.06.2011, at 23:49, Andreas Färber wrote: > Am 13.06.2011 um 15:31 schrieb Alexander Graf: > >> On 13.06.2011, at 12:13, Andreas Färber wrote: >> >>> +/* Memory forced */ >>> +ctx->raddr = ((sr & 0xF) << 28) | (eaddr & 0x0FFF); >> >> This is exactly the same as

Re: [Qemu-devel] [PATCH RFC] target-ppc: Correctly handle translation address when bus unit ID = 0x07F

2011-06-14 Thread Andreas Färber
Am 13.06.2011 um 15:31 schrieb Alexander Graf: On 13.06.2011, at 12:13, Andreas Färber wrote: +/* Memory forced */ +ctx->raddr = ((sr & 0xF) << 28) | (eaddr & 0x0FFF); This is exactly the same as ctx->raddr = eaddr, no? No, not that I see. The manual is explicit

Re: [Qemu-devel] [PATCH RFC] target-ppc: Correctly handle translation address when bus unit ID = 0x07F

2011-06-13 Thread Alexander Graf
On 13.06.2011, at 12:13, Andreas Färber wrote: > From: Hervé Poussineau > > In that case, we want to access memory space instead of I/O controller > interface address space. > > Signed-off-by: Hervé Poussineau > > Simplify by avoiding reindentation of existing code. > > Cc: Alexander Graf

[Qemu-devel] [PATCH RFC] target-ppc: Correctly handle translation address when bus unit ID = 0x07F

2011-06-13 Thread Andreas Färber
From: Hervé Poussineau In that case, we want to access memory space instead of I/O controller interface address space. Signed-off-by: Hervé Poussineau Simplify by avoiding reindentation of existing code. Cc: Alexander Graf Signed-off-by: Andreas Färber --- Hello Alex, This patch fixes a