Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-29 Thread Fei Li
On 10/26/2018 11:24 PM, Dr. David Alan Gilbert wrote: * Peter Xu (pet...@redhat.com) wrote: On Fri, Oct 26, 2018 at 09:10:19PM +0800, Fei Li wrote: On 10/25/2018 08:58 PM, Peter Xu wrote: On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote: [...] @@ -1325,22 +1325,24 @@ bool

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-26 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Oct 26, 2018 at 09:10:19PM +0800, Fei Li wrote: > > > > > > On 10/25/2018 08:58 PM, Peter Xu wrote: > > > On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote: > > > > > > [...] > > > > > > > @@ -1325,22 +1325,24 @@ bool

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-26 Thread Peter Xu
On Fri, Oct 26, 2018 at 09:10:19PM +0800, Fei Li wrote: > > > On 10/25/2018 08:58 PM, Peter Xu wrote: > > On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote: > > > > [...] > > > > > @@ -1325,22 +1325,24 @@ bool multifd_recv_all_channels_created(void) > > >  /* Return true if multifd is

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-26 Thread Fei Li
On 10/25/2018 08:58 PM, Peter Xu wrote: On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote: [...] @@ -1325,22 +1325,24 @@ bool multifd_recv_all_channels_created(void)  /* Return true if multifd is ready for the migration, otherwise false */  bool multifd_recv_new_channel(QIOChannel

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-26 Thread Fei Li
On 10/25/2018 08:55 PM, Dr. David Alan Gilbert wrote: * Fei Li (f...@suse.com) wrote: Hi, these two patches are to fix live migration issues. The first is about multifd, and the second is to fix some error handling. But I have a question about using multifd migration. In our current code,

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-25 Thread Peter Xu
On Thu, Oct 25, 2018 at 05:04:00PM +0800, Fei Li wrote: [...] > @@ -1325,22 +1325,24 @@ bool multifd_recv_all_channels_created(void) >  /* Return true if multifd is ready for the migration, otherwise false */ >  bool multifd_recv_new_channel(QIOChannel *ioc) >  { > +    MigrationIncomingState

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-25 Thread Dr. David Alan Gilbert
* Fei Li (f...@suse.com) wrote: > Hi, > these two patches are to fix live migration issues. The first is > about multifd, and the second is to fix some error handling. > > But I have a question about using multifd migration. > In our current code, when multifd is used during migration, if there >

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-25 Thread Fei Li
On 10/25/2018 05:27 AM, Peter Xu wrote: On Mon, Oct 22, 2018 at 07:08:52PM +0800, Fei Li wrote: Hi, these two patches are to fix live migration issues. The first is about multifd, and the second is to fix some error handling. But I have a question about using multifd migration. In our

Re: [Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-24 Thread Peter Xu
On Mon, Oct 22, 2018 at 07:08:52PM +0800, Fei Li wrote: > Hi, > these two patches are to fix live migration issues. The first is > about multifd, and the second is to fix some error handling. > > But I have a question about using multifd migration. > In our current code, when multifd is used

[Qemu-devel] [PATCH RFC 0/2] Fix migration issues

2018-10-22 Thread Fei Li
Hi, these two patches are to fix live migration issues. The first is about multifd, and the second is to fix some error handling. But I have a question about using multifd migration. In our current code, when multifd is used during migration, if there is an error before the destination receives