Re: [Qemu-devel] [PATCH RFC v1 01/29] target-arc: initial commit

2016-09-27 Thread Richard Henderson
On 09/25/2016 06:22 PM, Max Filippov wrote: > Hello, > > On Tue, Sep 20, 2016 at 4:31 PM, Richard Henderson wrote: >>> +if (ctx.npc == env->lpe) { >> You can't look at the contents of ENV during translation. >> >> You'll need to implement this feature similar to how

Re: [Qemu-devel] [PATCH RFC v1 01/29] target-arc: initial commit

2016-09-25 Thread Max Filippov
Hello, On Tue, Sep 20, 2016 at 4:31 PM, Richard Henderson wrote: >> +if (ctx.npc == env->lpe) { > You can't look at the contents of ENV during translation. > > You'll need to implement this feature similar to how it's done for xtensa. > See helper_wsr_lbeg,

Re: [Qemu-devel] [PATCH RFC v1 01/29] target-arc: initial commit

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +#define CPU_IMM(env)((env)->r[62]) +#define CPU_PCL(env)((env)->r[63]) You don't need to represent these as actual registers. These are better considered placeholder regnums to be filled in with actual values during translation.

[Qemu-devel] [PATCH RFC v1 01/29] target-arc: initial commit

2016-09-08 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- .gitignore | 2 + MAINTAINERS | 5 + arch_init.c | 2 + configure | 5 + default-configs/arc-softmmu.mak | 0 include/sysemu/arch_init.h | 1 +