Re: [Qemu-devel] [PATCH RFC v1 10/29] target-arc: POP, PUSH

2016-09-20 Thread Richard Henderson
On 09/08/2016 03:31 PM, Michael Rolnik wrote: +tcg_gen_subi_tl(cpu_sp, cpu_sp, 4); +tcg_gen_qemu_st_tl(src1, cpu_sp, ctx->memidx, MO_UL); You need to delay the write to the stack pointer until after the store, otherwise sp will have the incorrect contents if the page is not writable.

[Qemu-devel] [PATCH RFC v1 10/29] target-arc: POP, PUSH

2016-09-08 Thread Michael Rolnik
Signed-off-by: Michael Rolnik --- target-arc/translate-inst.c | 22 ++ target-arc/translate-inst.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/target-arc/translate-inst.c b/target-arc/translate-inst.c index 7f7e951..2a579f8 100644 --- a/target-arc/translate-inst.