Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-02-01 Thread Hailiang Zhang
On 2016/2/1 18:41, Daniel P. Berrange wrote: On Wed, Jan 27, 2016 at 04:29:37PM +0800, zhanghailiang wrote: Make the helper object_create() public and fix its first parameter to accept NULL value. Signed-off-by: zhanghailiang Cc: Paolo Bonzini --- v2: - New patch --- include/qemu-common.h

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-02-01 Thread Daniel P. Berrange
On Wed, Jan 27, 2016 at 04:29:37PM +0800, zhanghailiang wrote: > Make the helper object_create() public and fix its first > parameter to accept NULL value. > > Signed-off-by: zhanghailiang > Cc: Paolo Bonzini > --- > v2: > - New patch > --- > include/qemu-common.h | 2 ++ > vl.c

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-01-31 Thread Hailiang Zhang
On 2016/2/1 15:27, Jason Wang wrote: On 02/01/2016 02:19 PM, Hailiang Zhang wrote: On 2016/2/1 11:05, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: Make the helper object_create() public and fix its first parameter to accept NULL value. Looks not very nice. Maybe pass a

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-01-31 Thread Jason Wang
On 02/01/2016 02:19 PM, Hailiang Zhang wrote: > On 2016/2/1 11:05, Jason Wang wrote: >> >> >> On 01/27/2016 04:29 PM, zhanghailiang wrote: >>> Make the helper object_create() public and fix its first >>> parameter to accept NULL value. >> >> Looks not very nice. Maybe pass a new predicate func fo

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-01-31 Thread Hailiang Zhang
On 2016/2/1 11:05, Jason Wang wrote: On 01/27/2016 04:29 PM, zhanghailiang wrote: Make the helper object_create() public and fix its first parameter to accept NULL value. Looks not very nice. Maybe pass a new predicate func for sanity check it better. OK, but here is it better to check if

Re: [Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-01-31 Thread Jason Wang
On 01/27/2016 04:29 PM, zhanghailiang wrote: > Make the helper object_create() public and fix its first > parameter to accept NULL value. Looks not very nice. Maybe pass a new predicate func for sanity check it better. > > Signed-off-by: zhanghailiang > Cc: Paolo Bonzini > --- > v2: > - New

[Qemu-devel] [PATCH RFC v2 2/5] vl: Make object_create() public

2016-01-27 Thread zhanghailiang
Make the helper object_create() public and fix its first parameter to accept NULL value. Signed-off-by: zhanghailiang Cc: Paolo Bonzini --- v2: - New patch --- include/qemu-common.h | 2 ++ vl.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/q