Re: [Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-21 Thread Peter Xu
On Sun, Jan 22, 2017 at 04:42:13AM +, Tian, Kevin wrote: > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Friday, January 20, 2017 6:04 PM > > > > On Fri, Jan 20, 2017 at 09:52:01AM +, Tian, Kevin wrote: > > > > [...] > > > > > btw what about guest setups a valid mapping at

Re: [Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-21 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, January 20, 2017 6:04 PM > > On Fri, Jan 20, 2017 at 09:52:01AM +, Tian, Kevin wrote: > > [...] > > > btw what about guest setups a valid mapping at 0xFEEx_ in > > its remapping structure, which is then programmed to virtual >

Re: [Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-20 Thread Peter Xu
On Fri, Jan 20, 2017 at 09:52:01AM +, Tian, Kevin wrote: [...] > btw what about guest setups a valid mapping at 0xFEEx_ in > its remapping structure, which is then programmed to virtual > device as DMA destination? Then when emulating that virtual DMA, > vtd_do_iommu_translate should

Re: [Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-20 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, January 20, 2017 5:28 PM > > On Fri, Jan 20, 2017 at 09:15:27AM +, Tian, Kevin wrote: > > > From: Peter Xu [mailto:pet...@redhat.com] > > > Sent: Friday, January 20, 2017 5:05 PM > > > > > > On Fri, Jan 20, 2017 at 08:22:14AM +,

Re: [Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-20 Thread Peter Xu
On Fri, Jan 20, 2017 at 09:15:27AM +, Tian, Kevin wrote: > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Friday, January 20, 2017 5:05 PM > > > > On Fri, Jan 20, 2017 at 08:22:14AM +, Tian, Kevin wrote: > > > > From: Peter Xu [mailto:pet...@redhat.com] > > > > Sent: Friday,

Re: [Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-20 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, January 20, 2017 5:05 PM > > On Fri, Jan 20, 2017 at 08:22:14AM +, Tian, Kevin wrote: > > > From: Peter Xu [mailto:pet...@redhat.com] > > > Sent: Friday, January 13, 2017 11:06 AM > > > > > > Before we have int-remap, we need to

Re: [Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-20 Thread Peter Xu
On Fri, Jan 20, 2017 at 08:22:14AM +, Tian, Kevin wrote: > > From: Peter Xu [mailto:pet...@redhat.com] > > Sent: Friday, January 13, 2017 11:06 AM > > > > Before we have int-remap, we need to bypass interrupt write requests. > > That's not necessary now - we have supported int-remap, and all

Re: [Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-20 Thread Tian, Kevin
> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, January 13, 2017 11:06 AM > > Before we have int-remap, we need to bypass interrupt write requests. > That's not necessary now - we have supported int-remap, and all the irq > region requests should be redirected there. Cleaning up the

[Qemu-devel] [PATCH RFC v3 02/14] intel_iommu: simplify irq region translation

2017-01-12 Thread Peter Xu
Before we have int-remap, we need to bypass interrupt write requests. That's not necessary now - we have supported int-remap, and all the irq region requests should be redirected there. Cleaning up the block with an assertion instead. Signed-off-by: Peter Xu ---