Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling

2017-01-13 Thread Jason Wang
On 2017年01月13日 17:13, Peter Xu wrote: On Fri, Jan 13, 2017 at 03:46:31PM +0800, Jason Wang wrote: On 2017年01月13日 11:06, Peter Xu wrote: VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting usef

Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling

2017-01-13 Thread Peter Xu
On Fri, Jan 13, 2017 at 03:46:31PM +0800, Jason Wang wrote: > > > On 2017年01月13日 11:06, Peter Xu wrote: > >VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not > >good, and we should end the day when we need to recompile the code > >before getting useful debugging information for

Re: [Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling

2017-01-12 Thread Jason Wang
On 2017年01月13日 11:06, Peter Xu wrote: VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting useful debugging information for vt-d. Time to switch to the trace system. This is the first patch to do

[Qemu-devel] [PATCH RFC v3 04/14] intel_iommu: fix trace for inv desc handling

2017-01-12 Thread Peter Xu
VT-d codes are still using static DEBUG_INTEL_IOMMU macro. That's not good, and we should end the day when we need to recompile the code before getting useful debugging information for vt-d. Time to switch to the trace system. This is the first patch to do it. Generally, the rule of mine is: - f