Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/18/2015 02:56 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/18/2015 04:11 AM, Eric Blake wrote: >>> On 09/17/2015 08:34 AM, Eric Blake wrote: >>> > > I apply Markus's v8 patch and this series, make check will fail: > TEST:

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/18/2015 04:11 AM, Eric Blake wrote: On 09/17/2015 08:34 AM, Eric Blake wrote: I apply Markus's v8 patch and this series, make check will fail: TEST: tests/virtio-net-test... (pid=23648) /x86_64/virtio/net/pci/basic: qemu-system-x86_64:

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/18/2015 12:56 AM, Markus Armbruster wrote: >> OK, I will try it. What is difference between start_struct() and >> start_implicit_struct()? > > I hope to be able to answer this question next week, after taking a dive > in the (almost entirely undocumented) visitors code. It's not quite

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/18/2015 03:03 AM, Yang Hongyang wrote: >> Fix is simple: add this patch to your build: >> >> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01650.html >> >> I've rebased my git repo accordingly for now, and will post v5 later on >> (I'm still working on other improvements, and may

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/17/2015 06:52 PM, Wen Congyang wrote: >> > > OK, I will try it. What is difference between start_struct() and > start_implicit_struct()? If you have the following QDict: { "a":1, "b":2", "c:3" } start_struct() corresponds to the {, and end_struct() corresponds to the }. If the

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

Wen Congyang writes: > On 09/18/2015 04:11 AM, Eric Blake wrote: >> On 09/17/2015 08:34 AM, Eric Blake wrote: >> I apply Markus's v8 patch and this series, make check will fail: TEST: tests/virtio-net-test... (pid=23648) /x86_64/virtio/net/pci/basic:

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/10/2015 12:06 PM, Eric Blake wrote: > From: Kővágó, Zoltán > > Except qapi-schema.json, this patch was generated by: > > find . -name .git -prune -o -type f \! -name '*~' -print0 | \ > xargs -0 sed -i \ > -e 's/NetClientOptionsKind/NetClientDriver/g' \ >

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/17/2015 03:15 AM, Wen Congyang wrote: > On 09/10/2015 12:06 PM, Eric Blake wrote: >> From: Kővágó, Zoltán >> >> Except qapi-schema.json, this patch was generated by: >> >> find . -name .git -prune -o -type f \! -name '*~' -print0 | \ >> xargs -0 sed -i \ >> -e

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/17/2015 08:34 AM, Eric Blake wrote: >> >> I apply Markus's v8 patch and this series, make check will fail: >> TEST: tests/virtio-net-test... (pid=23648) >> /x86_64/virtio/net/pci/basic: >> qemu-system-x86_64: -netdev socket,fd=6,id=hs0: Invalid

Re: [Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

On 09/18/2015 04:11 AM, Eric Blake wrote: > On 09/17/2015 08:34 AM, Eric Blake wrote: > >>> >>> I apply Markus's v8 patch and this series, make check will fail: >>> TEST: tests/virtio-net-test... (pid=23648) >>> /x86_64/virtio/net/pci/basic: >>>

[Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

From: Kővágó, Zoltán Except qapi-schema.json, this patch was generated by: find . -name .git -prune -o -type f \! -name '*~' -print0 | \ xargs -0 sed -i \ -e 's/NetClientOptionsKind/NetClientDriver/g' \ -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \