Re: [Qemu-devel] [PATCH V2 1/3] Darwin: Fix incorrect check for fdatasync() in configure

2011-06-01 Thread Andreas Färber
Thanks, applied to the cocoa branch with a modified description. Am 30.05.2011 um 04:32 schrieb Alexandre Raymond: I didn't notice anything broken. I just stumbled upon this bug while reviewing the code. Alexandre On Sun, May 29, 2011 at 8:09 PM, Alexandre Raymond cerb...@gmail.com wrote:

[Qemu-devel] [PATCH V2 1/3] Darwin: Fix incorrect check for fdatasync() in configure

2011-05-29 Thread Alexandre Raymond
Under darwin (OS X 10.6.7), a symbol exists for the fdatasync() method but it is not supported because _POSIX_SYNCHRONIZED_IO is set to '-1'. Enable fdatasync() only if _POSIX_SYNCHRONIZED_IO is '0', as per The Open Group Base Specifications Issue 7. Signed-off-by: Alexandre Raymond

Re: [Qemu-devel] [PATCH V2 1/3] Darwin: Fix incorrect check for fdatasync() in configure

2011-05-29 Thread Andreas Färber
Am 30.05.2011 um 00:22 schrieb Alexandre Raymond: Under darwin (OS X 10.6.7), a symbol exists for the fdatasync() method but it is not supported because _POSIX_SYNCHRONIZED_IO is set to '-1'. Question: How did you notice? Did anything break that we could mention, or did you just review the