Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-08 Thread Michael S. Tsirkin
On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote: > The virtio devices are converted to PCI-Express > if they are plugged into a PCI-Express bus and > the 'modern' protocol is enabled. > > Devices plugged directly into the Root Complex as > Integrated Endpoints remain PCI. > >

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-08 Thread Marcel Apfelbaum
On 11/08/2015 07:10 PM, Michael S. Tsirkin wrote: On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote: The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Devices plugged directly into the Root Complex as

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-05 Thread Eduardo Habkost
On Mon, Nov 02, 2015 at 02:12:32PM +0200, Marcel Apfelbaum wrote: > On 11/02/2015 02:05 PM, Cornelia Huck wrote: [...] > >What's the word on compat machines and new device types, btw.? If we > >fire up a compat machine, we can still specify devices that were added > >with later machine versions,

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-05 Thread Marcel Apfelbaum
On 11/05/2015 08:22 PM, Dr. David Alan Gilbert wrote: * Eduardo Habkost (ehabk...@redhat.com) wrote: On Mon, Nov 02, 2015 at 02:12:32PM +0200, Marcel Apfelbaum wrote: On 11/02/2015 02:05 PM, Cornelia Huck wrote: [...] What's the word on compat machines and new device types, btw.? If we fire

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-05 Thread Dr. David Alan Gilbert
* Marcel Apfelbaum (mar...@redhat.com) wrote: > On 11/05/2015 08:22 PM, Dr. David Alan Gilbert wrote: > >* Eduardo Habkost (ehabk...@redhat.com) wrote: > >>On Mon, Nov 02, 2015 at 02:12:32PM +0200, Marcel Apfelbaum wrote: > >>>On 11/02/2015 02:05 PM, Cornelia Huck wrote: > >>[...] > What's the

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-05 Thread Dr. David Alan Gilbert
* Eduardo Habkost (ehabk...@redhat.com) wrote: > On Mon, Nov 02, 2015 at 02:12:32PM +0200, Marcel Apfelbaum wrote: > > On 11/02/2015 02:05 PM, Cornelia Huck wrote: > [...] > > >What's the word on compat machines and new device types, btw.? If we > > >fire up a compat machine, we can still specify

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-02 Thread Cornelia Huck
On Sun, 1 Nov 2015 11:15:24 +0200 Marcel Apfelbaum wrote: > By the way, HW_COMPAT_2_3 sets any-layout to off only for a few virtio > devices, > not for all. Does anybody know if is in purpose or can we do the same for > them too? net and scsi already defaulted any_layout to

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-02 Thread Greg Kurz
On Thu, 29 Oct 2015 13:56:28 +0200 Marcel Apfelbaum wrote: > The virtio devices are converted to PCI-Express > if they are plugged into a PCI-Express bus and > the 'modern' protocol is enabled. > > Devices plugged directly into the Root Complex as > Integrated Endpoints

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-02 Thread Marcel Apfelbaum
On 11/02/2015 11:42 AM, Greg Kurz wrote: On Thu, 29 Oct 2015 13:56:28 +0200 Marcel Apfelbaum wrote: The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Devices plugged directly into the Root

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-02 Thread Marcel Apfelbaum
On 11/02/2015 11:07 AM, Cornelia Huck wrote: On Sun, 1 Nov 2015 11:15:24 +0200 Marcel Apfelbaum wrote: By the way, HW_COMPAT_2_3 sets any-layout to off only for a few virtio devices, not for all. Does anybody know if is in purpose or can we do the same for them too? net

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-02 Thread Cornelia Huck
On Mon, 2 Nov 2015 11:20:50 +0200 Marcel Apfelbaum wrote: > On 11/02/2015 11:07 AM, Cornelia Huck wrote: > > On Sun, 1 Nov 2015 11:15:24 +0200 > > Marcel Apfelbaum wrote: > > > >> By the way, HW_COMPAT_2_3 sets any-layout to off only for a few virtio > >>

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-02 Thread Marcel Apfelbaum
On 11/02/2015 11:54 AM, Cornelia Huck wrote: On Mon, 2 Nov 2015 11:20:50 +0200 Marcel Apfelbaum wrote: On 11/02/2015 11:07 AM, Cornelia Huck wrote: On Sun, 1 Nov 2015 11:15:24 +0200 Marcel Apfelbaum wrote: By the way, HW_COMPAT_2_3 sets any-layout to

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-02 Thread Cornelia Huck
On Mon, 2 Nov 2015 12:01:06 +0200 Marcel Apfelbaum wrote: > On 11/02/2015 11:54 AM, Cornelia Huck wrote: > > On Mon, 2 Nov 2015 11:20:50 +0200 > > Marcel Apfelbaum wrote: > > > >> On 11/02/2015 11:07 AM, Cornelia Huck wrote: > >>> On Sun, 1 Nov 2015

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-02 Thread Marcel Apfelbaum
On 11/02/2015 02:05 PM, Cornelia Huck wrote: On Mon, 2 Nov 2015 12:01:06 +0200 Marcel Apfelbaum wrote: On 11/02/2015 11:54 AM, Cornelia Huck wrote: On Mon, 2 Nov 2015 11:20:50 +0200 Marcel Apfelbaum wrote: On 11/02/2015 11:07 AM, Cornelia Huck wrote:

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-11-01 Thread Marcel Apfelbaum
On 10/30/2015 05:20 PM, Eduardo Habkost wrote: On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote: [...] index 095de5d..0a08531 100644 --- a/include/hw/compat.h +++ b/include/hw/compat.h @@ -2,7 +2,51 @@ #define HW_COMPAT_H #define HW_COMPAT_2_4 \ -/* empty */ +

Re: [Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-10-30 Thread Eduardo Habkost
On Thu, Oct 29, 2015 at 01:56:28PM +0200, Marcel Apfelbaum wrote: [...] > index 095de5d..0a08531 100644 > --- a/include/hw/compat.h > +++ b/include/hw/compat.h > @@ -2,7 +2,51 @@ > #define HW_COMPAT_H > > #define HW_COMPAT_2_4 \ > -/* empty */ > +{\ > +.driver =

[Qemu-devel] [PATCH V3] hw/virtio: Add PCIe capability to virtio devices

2015-10-29 Thread Marcel Apfelbaum
The virtio devices are converted to PCI-Express if they are plugged into a PCI-Express bus and the 'modern' protocol is enabled. Devices plugged directly into the Root Complex as Integrated Endpoints remain PCI. Signed-off-by: Marcel Apfelbaum --- v2 -> v3: - Addressed