Re: [Qemu-devel] [PATCH V3 2/2] target-arm: Guest cpu endianness determination for virtio KVM ARM/ARM64

2015-02-06 Thread Pranavkumar Sawargaonkar
Hi PMM, On 5 February 2015 at 17:18, Peter Maydell wrote: > On 5 February 2015 at 11:43, Peter Maydell wrote: >> On 5 February 2015 at 09:59, Pranavkumar Sawargaonkar >> wrote: >>> + >>> +/* In 32bit guest endianess is determined by looking at CPSR's E bit */ >>> +if (!is_a64(env)) { >>

Re: [Qemu-devel] [PATCH V3 2/2] target-arm: Guest cpu endianness determination for virtio KVM ARM/ARM64

2015-02-05 Thread Peter Maydell
On 5 February 2015 at 11:43, Peter Maydell wrote: > On 5 February 2015 at 09:59, Pranavkumar Sawargaonkar > wrote: >> + >> +/* In 32bit guest endianess is determined by looking at CPSR's E bit */ >> +if (!is_a64(env)) { >> +return (env->pstate & CPSR_E) ? 1 : 0; > > This is wrong,

Re: [Qemu-devel] [PATCH V3 2/2] target-arm: Guest cpu endianness determination for virtio KVM ARM/ARM64

2015-02-05 Thread Peter Maydell
On 5 February 2015 at 09:59, Pranavkumar Sawargaonkar wrote: > This patch implements a fucntion pointer "virtio_is_big_endian" > from "CPUClass" structure for arm/arm64. > Function arm_cpu_is_big_endian() is added to determine and > return the guest cpu endianness to virtio. > This is required for

[Qemu-devel] [PATCH V3 2/2] target-arm: Guest cpu endianness determination for virtio KVM ARM/ARM64

2015-02-05 Thread Pranavkumar Sawargaonkar
This patch implements a fucntion pointer "virtio_is_big_endian" from "CPUClass" structure for arm/arm64. Function arm_cpu_is_big_endian() is added to determine and return the guest cpu endianness to virtio. This is required for running cross endian guests with virtio on ARM/ARM64. Signed-off-by: P