Re: [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features

2013-07-26 Thread Eric Blake
On 07/23/2013 10:29 AM, Benoît Canet wrote: The first patch fixes the throttling which was broken by a previous commit. The next patch replace the existing throttling algorithm by the well described leaky bucket algorithm. Third patch implement bursting by adding *_threshold parameters to

Re: [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features

2013-07-25 Thread Fam Zheng
On Tue, 07/23 18:29, Benoît Canet wrote: The first patch fixes the throttling which was broken by a previous commit. The next patch replace the existing throttling algorithm by the well described leaky bucket algorithm. Third patch implement bursting by adding *_threshold parameters to

Re: [Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features

2013-07-25 Thread Benoît Canet
Le Thursday 25 Jul 2013 à 20:08:22 (+0800), Fam Zheng a écrit : My ignorant question: Besides the fix, how is io throttling improved from previously, what are the advantages of leaky bucket algorithm? The advantage is simplicity and the ability to allow controlled bursts. The disavantage is it

[Qemu-devel] [PATCH V3 for-1.6 0/5] Leaky bucket throttling and features

2013-07-23 Thread Benoît Canet
The first patch fixes the throttling which was broken by a previous commit. The next patch replace the existing throttling algorithm by the well described leaky bucket algorithm. Third patch implement bursting by adding *_threshold parameters to qmp_block_set_io_throttle. The last one allow to