Re: [Qemu-devel] [PATCH V3 for-1.6 1/5] block: Repair the throttling code.

2013-07-26 Thread Eric Blake
On 07/23/2013 10:29 AM, Benoît Canet wrote: The throttling code was segfaulting since commit 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next caller does not run in a coroutine. qemu_co_queue_do_restart assume that the caller is a coroutinne. s/assume/assumes/;

Re: [Qemu-devel] [PATCH V3 for-1.6 1/5] block: Repair the throttling code.

2013-07-26 Thread Alex Bligh
--On 26 July 2013 13:16:04 -0600 Eric Blake ebl...@redhat.com wrote: -while (qemu_co_queue_next(bs-throttled_reqs)); +while (qemu_co_enter_next(bs-throttled_reqs)) { +} On first read, I missed the s/queue/enter/ change and thought all you were doing was the s/;/{}/ change. Is

[Qemu-devel] [PATCH V3 for-1.6 1/5] block: Repair the throttling code.

2013-07-23 Thread Benoît Canet
The throttling code was segfaulting since commit 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next caller does not run in a coroutine. qemu_co_queue_do_restart assume that the caller is a coroutinne. As suggested by Stefan fix this by entering the coroutine directly. Also