Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-08-09 Thread Kevin Wolf
Am 08.08.2013 um 15:37 hat Benoît Canet geschrieben: Kevin's series renamed these to have a dash in the name, and also moved all the throttling parameters into a sub-struct. Does it make more sense to have just '*throttling' with that sub-struct containing 12 parameters, 6 for limits and

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-08-08 Thread Benoît Canet
Kevin's series renamed these to have a dash in the name, and also moved all the throttling parameters into a sub-struct. Does it make more sense to have just '*throttling' with that sub-struct containing 12 parameters, 6 for limits and 6 for thresholds, or would it be better to have

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-07-26 Thread Eric Blake
On 07/23/2013 10:29 AM, Benoît Canet wrote: The thresholds of the leaky bucket algorithm can be used to allow some burstiness. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/qapi.c | 24 + blockdev.c | 105

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-07-26 Thread Benoît Canet
Kevin's series renamed these to have a dash in the name, and also moved all the throttling parameters into a sub-struct. Does it make more sense to have just '*throttling' with that sub-struct containing 12 parameters, 6 for limits and 6 for thresholds, or would it be better to have

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-07-25 Thread Fam Zheng
On Tue, 07/23 18:29, Benoît Canet wrote: The thresholds of the leaky bucket algorithm can be used to allow some burstiness. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/qapi.c | 24 + blockdev.c | 105

[Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.

2013-07-23 Thread Benoît Canet
The thresholds of the leaky bucket algorithm can be used to allow some burstiness. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/qapi.c | 24 + blockdev.c | 105 +++--- hmp.c| 32 +++--