Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Junyan He
't nice, passing an 'ops' pointer in is better. However if you can do the 'flush before complete' instead then the amount of code change is a LOT smaller. The only other question is whether from your pmem view, the flush-before-complete causes any problems; in the worst c

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Dr. David Alan Gilbert
T smaller. The only other question is whether from your pmem view, the flush-before-complete causes any problems; in the worst case, how long could the flush take? Dave > > From: Stefan Hajnoczi > Sent: Thursday, May 31, 2018 1:18:58 PM > To: junyan..

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Dr. David Alan Gilbert
* Stefan Hajnoczi (stefa...@gmail.com) wrote: > David Gilbert previously suggested a memory access interface. I guess > it would look something like this: > > typedef struct { > void (*memset)(void *s, int c, size_t n); > void (*memcpy)(void *dest, const void *src, size_t n); > }

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Junyan He
@gmx.com Cc: qemu-devel@nongnu.org; Haozhong Zhang; xiaoguangrong.e...@gmail.com; crosthwaite.pe...@gmail.com; m...@redhat.com; dgilb...@redhat.com; ehabk...@redhat.com; quint...@redhat.com; Junyan He; stefa...@redhat.com; pbonz...@redhat.com; imamm...@redhat.com; r...@twiddle.net Subject: Re: [Qe

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-31 Thread Stefan Hajnoczi
David Gilbert previously suggested a memory access interface. I guess it would look something like this: typedef struct { void (*memset)(void *s, int c, size_t n); void (*memcpy)(void *dest, const void *src, size_t n); } MemoryOperations; That way code doesn't need if (pmem) A el

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-27 Thread Junyan He
redhat.com, quint...@redhat.com, "Junyan He" , stefa...@redhat.com, pbonz...@redhat.com, imamm...@redhat.com, r...@twiddle.net Subject: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory From: Junyan He QEMU writes to vNVDIMM

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-20 Thread Junyan He
, quint...@redhat.com, "Junyan He" , stefa...@redhat.com, pbonz...@redhat.com, imamm...@redhat.com, r...@twiddle.net Subject: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory From: Junyan He QEMU writes to vNVDIMM backends in the vNV

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-10 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1525918138-6189-1-git-send-email-junyan...@gmx.com Subject: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory === TEST SCRIPT BEGIN === #!/bin

Re: [Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-09 Thread He, Junyan
> > > > > > 2. The migration/ram code is invasive. Is it really necessary to > > >persist data each time pages are loaded from a migration stream? It > > >seems simpler to migrate as normal and call pmem_persist() just once > > >after RAM has been migrated but before the migration co

[Qemu-devel] [PATCH V5 0/9] nvdimm: guarantee persistence of QEMU writes to persistent memory

2018-05-09 Thread junyan . he
From: Junyan He QEMU writes to vNVDIMM backends in the vNVDIMM label emulation and live migration. If the backend is on the persistent memory, QEMU needs to take proper operations to ensure its writes persistent on the persistent memory. Otherwise, a host power failure may result in the loss the