Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Jan Kiszka
On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot access memory at address 0x88013fffd3a0 (gdb) I suppose this is x86-64, not

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Paolo Bonzini
Il 18/03/2014 08:19, Jan Kiszka ha scritto: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot access memory at address 0x88013fffd3a0

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Jan Kiszka
On 2014-03-18 08:36, Paolo Bonzini wrote: Il 18/03/2014 08:19, Jan Kiszka ha scritto: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Luiz Capitulino
On Tue, 18 Mar 2014 08:19:52 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Luiz Capitulino
On Tue, 18 Mar 2014 11:30:42 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2014-03-18 08:36, Paolo Bonzini wrote: Il 18/03/2014 08:19, Jan Kiszka ha scritto: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Jan Kiszka
On 2014-03-18 14:00, Luiz Capitulino wrote: On Tue, 18 Mar 2014 11:30:42 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2014-03-18 08:36, Paolo Bonzini wrote: Il 18/03/2014 08:19, Jan Kiszka ha scritto: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Luiz Capitulino
On Tue, 18 Mar 2014 15:36:45 +0100 Jan Kiszka jan.kis...@siemens.com wrote: Right, this belongs in the if (env-hflags HF_LMA_MASK) block. And the subject or description should mention that x86_cpu_get_phys_page_debug was lacking support for 1G hugepages. To be honest, although the

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Paolo Bonzini
Il 18/03/2014 17:23, Luiz Capitulino ha scritto: On Tue, 18 Mar 2014 15:36:45 +0100 Jan Kiszka jan.kis...@siemens.com wrote: Right, this belongs in the if (env-hflags HF_LMA_MASK) block. And the subject or description should mention that x86_cpu_get_phys_page_debug was lacking support for 1G

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Jan Kiszka
On 2014-03-18 17:37, Paolo Bonzini wrote: Il 18/03/2014 17:23, Luiz Capitulino ha scritto: On Tue, 18 Mar 2014 15:36:45 +0100 Jan Kiszka jan.kis...@siemens.com wrote: Right, this belongs in the if (env-hflags HF_LMA_MASK) block. And the subject or description should mention that

[Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-17 Thread Luiz Capitulino
If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot access memory at address 0x88013fffd3a0 (gdb) I debugged this down to x86_cpu_get_phys_page_debug(), it doesn't handle the case