Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-26 Thread Fam Zheng
On Tue, 12/26 11:57, Vladimir Sementsov-Ogievskiy wrote: > 26.12.2017 10:07, Fam Zheng wrote: > > On Wed, 12/20 11:20, Vladimir Sementsov-Ogievskiy wrote: > > > external backup: > > > > > > 0. we have active_disk and attached to it dirty bitmap bitmap0 > > > 1. qmp blockdev-add tmp_disk

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-26 Thread Vladimir Sementsov-Ogievskiy
26.12.2017 10:07, Fam Zheng wrote: On Wed, 12/20 11:20, Vladimir Sementsov-Ogievskiy wrote: external backup: 0. we have active_disk and attached to it dirty bitmap bitmap0 1. qmp blockdev-add tmp_disk (backing=active_disk) 2. guest fsfreeze 3. qmp transaction:     - block-dirty-bitmap-add

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-25 Thread Fam Zheng
On Wed, 12/20 11:20, Vladimir Sementsov-Ogievskiy wrote: > external backup: > > 0. we have active_disk and attached to it dirty bitmap bitmap0 > 1. qmp blockdev-add tmp_disk (backing=active_disk) > 2. guest fsfreeze > 3. qmp transaction: >     - block-dirty-bitmap-add node=active_disk

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-20 Thread Kirill Korotaev
Lets me add a couple of words from backup vendor side: 1. pull backup is very important to have, it enables additional important functionality: 1. User can select separate volumes (rather then disks) to backup 2. User can select specific files/folders to backup (!) 3. Backup software can

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-20 Thread Vladimir Sementsov-Ogievskiy
20.12.2017 04:06, John Snow wrote: On 12/19/2017 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: 13.12.2017 07:12, Fam Zheng wrote: On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup API. Using these three

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-20 Thread Nikolay Shirokovskiy
On 20.12.2017 04:06, John Snow wrote: > > > On 12/19/2017 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: >> 13.12.2017 07:12, Fam Zheng wrote: >>> On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-19 Thread John Snow
On 12/19/2017 11:07 AM, Vladimir Sementsov-Ogievskiy wrote: > 13.12.2017 07:12, Fam Zheng wrote: >> On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all. >>> >>> There are three qmp commands, needed to implement external backup API. >>> >>> Using these three commands, client may

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-19 Thread Vladimir Sementsov-Ogievskiy
13.12.2017 07:12, Fam Zheng wrote: On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup API. Using these three commands, client may do all needed bitmap management by hand: on backup start we need to do a

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-12 Thread Fam Zheng
On Mon, 11/13 19:20, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > There are three qmp commands, needed to implement external backup API. > > Using these three commands, client may do all needed bitmap management by > hand: > > on backup start we need to do a transaction: > {disable old

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-12 Thread John Snow
On 12/11/2017 07:18 AM, Vladimir Sementsov-Ogievskiy wrote: > 11.12.2017 14:15, Kevin Wolf wrote: >> Am 09.12.2017 um 01:57 hat John Snow geschrieben: >>> Here's an idea of what this API might look like without revealing >>> explicit merge/split primitives. >>> >>> A new bitmap property that

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-12 Thread Kevin Wolf
Am 11.12.2017 um 19:40 hat John Snow geschrieben: > > > On 12/11/2017 06:15 AM, Kevin Wolf wrote: > > Am 09.12.2017 um 01:57 hat John Snow geschrieben: > >> Here's an idea of what this API might look like without revealing > >> explicit merge/split primitives. > >> > >> A new bitmap property

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread John Snow
On 12/11/2017 06:15 AM, Kevin Wolf wrote: > Am 09.12.2017 um 01:57 hat John Snow geschrieben: >> Here's an idea of what this API might look like without revealing >> explicit merge/split primitives. >> >> A new bitmap property that lets us set retention: >> >> :: block-dirty-bitmap-set-retention

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
11.12.2017 14:15, Kevin Wolf wrote: Am 09.12.2017 um 01:57 hat John Snow geschrieben: Here's an idea of what this API might look like without revealing explicit merge/split primitives. A new bitmap property that lets us set retention: :: block-dirty-bitmap-set-retention bitmap=foo slices=10

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Kevin Wolf
Am 09.12.2017 um 01:57 hat John Snow geschrieben: > Here's an idea of what this API might look like without revealing > explicit merge/split primitives. > > A new bitmap property that lets us set retention: > > :: block-dirty-bitmap-set-retention bitmap=foo slices=10 > > Or something similar,

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-11 Thread Denis V. Lunev
On 12/09/2017 03:57 AM, John Snow wrote: > This is going to be a long one. Maybe go get a cup of coffee. > > On 12/07/2017 04:39 AM, Vladimir Sementsov-Ogievskiy wrote: >> 07.12.2017 03:38, John Snow wrote: >>> I'm sorry, I don't think I understand. >>> >>> "customers needs a possibility to create

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-08 Thread John Snow
This is going to be a long one. Maybe go get a cup of coffee. On 12/07/2017 04:39 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.12.2017 03:38, John Snow wrote: >> I'm sorry, I don't think I understand. >> >> "customers needs a possibility to create a backup of data changed since >> some point in

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-07 Thread Vladimir Sementsov-Ogievskiy
07.12.2017 03:38, John Snow wrote: On 11/30/2017 07:10 AM, Vladimir Sementsov-Ogievskiy wrote: 18.11.2017 00:35, John Snow wrote: On 11/17/2017 03:22 AM, Vladimir Sementsov-Ogievskiy wrote: 17.11.2017 06:10, John Snow wrote: On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote:

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-12-06 Thread John Snow
On 11/30/2017 07:10 AM, Vladimir Sementsov-Ogievskiy wrote: > 18.11.2017 00:35, John Snow wrote: >> >> On 11/17/2017 03:22 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 17.11.2017 06:10, John Snow wrote: On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.11.2017 00:20, John

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-30 Thread Vladimir Sementsov-Ogievskiy
18.11.2017 00:35, John Snow wrote: On 11/17/2017 03:22 AM, Vladimir Sementsov-Ogievskiy wrote: 17.11.2017 06:10, John Snow wrote: On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: 16.11.2017 00:20, John Snow wrote: On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: Hi

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-27 Thread Kevin Wolf
Am 24.11.2017 um 16:01 hat Vladimir Sementsov-Ogievskiy geschrieben: > John, Kevin, do we reach a consensus? Can we go on with this? I don't know the details of this, so I can't really offer a strong opinion. I gave a high-level perspective of what we're doing in other places and that's all I was

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-24 Thread Vladimir Sementsov-Ogievskiy
John, Kevin, do we reach a consensus? Can we go on with this? 20.11.2017 19:00, Denis V. Lunev wrote: On 11/17/2017 06:10 AM, John Snow wrote: On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: 16.11.2017 00:20, John Snow wrote: On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-22 Thread Vladimir Sementsov-Ogievskiy
22.11.2017 03:10, John Snow wrote: On 11/21/2017 12:23 PM, Kevin Wolf wrote: Am 17.11.2017 um 22:35 hat John Snow geschrieben: usage is like this: 1. we have dirty bitmap bitmap0 for incremental backup. 2. prepare image fleecing (create temporary image with backing=our_disk) 3. in qmp

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-21 Thread John Snow
On 11/21/2017 12:23 PM, Kevin Wolf wrote: > Am 17.11.2017 um 22:35 hat John Snow geschrieben: > usage is like this: > > 1. we have dirty bitmap bitmap0 for incremental backup. > > 2. prepare image fleecing (create temporary image with backing=our_disk) > 3. in qmp

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-21 Thread Kevin Wolf
Am 17.11.2017 um 22:35 hat John Snow geschrieben: > >>> usage is like this: > >>> > >>> 1. we have dirty bitmap bitmap0 for incremental backup. > >>> > >>> 2. prepare image fleecing (create temporary image with backing=our_disk) > >>> 3. in qmp transaction: > >>>     - disable bitmap0 > >>>     -

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-20 Thread Denis V. Lunev
On 11/17/2017 06:10 AM, John Snow wrote: > > On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: >> 16.11.2017 00:20, John Snow wrote: >>> On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-17 Thread John Snow
On 11/17/2017 03:22 AM, Vladimir Sementsov-Ogievskiy wrote: > 17.11.2017 06:10, John Snow wrote: >> >> On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: >>> 16.11.2017 00:20, John Snow wrote: On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > >

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-17 Thread Vladimir Sementsov-Ogievskiy
17.11.2017 06:10, John Snow wrote: On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: 16.11.2017 00:20, John Snow wrote: On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup API. Using these three

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-16 Thread John Snow
On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: > 16.11.2017 00:20, John Snow wrote: >> >> On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi all. >>> >>> There are three qmp commands, needed to implement external backup API. >>> >>> Using these three commands, client

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-16 Thread Vladimir Sementsov-Ogievskiy
16.11.2017 00:20, John Snow wrote: On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are three qmp commands, needed to implement external backup API. Using these three commands, client may do all needed bitmap management by hand: on backup start we need to do a

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-15 Thread John Snow
On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all. > > There are three qmp commands, needed to implement external backup API. > > Using these three commands, client may do all needed bitmap management by > hand: > > on backup start we need to do a transaction: > {disable

[Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-13 Thread Vladimir Sementsov-Ogievskiy
Hi all. There are three qmp commands, needed to implement external backup API. Using these three commands, client may do all needed bitmap management by hand: on backup start we need to do a transaction: {disable old bitmap, create new bitmap} on backup success: drop old bitmap on backup