Re: [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-08-13 Thread Jason J. Herne
On 07/21/2015 06:37 AM, David Hildenbrand wrote: So if I've got this code right, you send here a header that announces a packet with all pages ... +while (handled_count total_count) { +cur_count = MIN(total_count - handled_count, S390_SKEYS_BUFFER_SIZE); + +ret =

Re: [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-08-13 Thread Christian Borntraeger
Am 21.07.2015 um 12:37 schrieb David Hildenbrand: So if I've got this code right, you send here a header that announces a packet with all pages ... +while (handled_count total_count) { +cur_count = MIN(total_count - handled_count, S390_SKEYS_BUFFER_SIZE); + +ret =

Re: [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-07-30 Thread Jason J. Herne
On 07/21/2015 06:37 AM, David Hildenbrand wrote: So if I've got this code right, you send here a header that announces a packet with all pages ... +while (handled_count total_count) { +cur_count = MIN(total_count - handled_count, S390_SKEYS_BUFFER_SIZE); + +ret =

Re: [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-07-30 Thread Thomas Huth
On 30/07/15 17:00, Jason J. Herne wrote: On 07/21/2015 06:37 AM, David Hildenbrand wrote: So if I've got this code right, you send here a header that announces a packet with all pages ... +while (handled_count total_count) { +cur_count = MIN(total_count - handled_count,

Re: [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-07-21 Thread Thomas Huth
On 20/07/15 15:49, Cornelia Huck wrote: From: Jason J. Herne jjhe...@linux.vnet.ibm.com Routines to save/load guest storage keys are provided. register_savevm is called to register them as migration handlers. We prepare the protocol to support more complex parameters. So we will later be

Re: [Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-07-21 Thread David Hildenbrand
So if I've got this code right, you send here a header that announces a packet with all pages ... +while (handled_count total_count) { +cur_count = MIN(total_count - handled_count, S390_SKEYS_BUFFER_SIZE); + +ret = skeyclass-get_skeys(ss, cur_gfn, cur_count,

[Qemu-devel] [PATCH for-2.5 7/8] s390x: Migrate guest storage keys (initial memory only)

2015-07-20 Thread Cornelia Huck
From: Jason J. Herne jjhe...@linux.vnet.ibm.com Routines to save/load guest storage keys are provided. register_savevm is called to register them as migration handlers. We prepare the protocol to support more complex parameters. So we will later be able to support standby memory (having empty