Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression

2016-04-13 Thread Kevin Wolf
Am 13.04.2016 um 17:40 hat Jeff Cody geschrieben: > On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote: > > Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC > > over to using blk_pwrite() instead of bdrv_pwrite_sync(). The > > return value of bdrv_pwrite_sync() was always 0 fo

Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression

2016-04-13 Thread Jeff Cody
On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote: > Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC > over to using blk_pwrite() instead of bdrv_pwrite_sync(). The > return value of bdrv_pwrite_sync() was always 0 for success, and > create_dynamic_disk() in one instance che

Re: [Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression

2016-03-23 Thread Stefan Hajnoczi
On Tue, Mar 22, 2016 at 11:33:38PM -0400, Jeff Cody wrote: > This fails silently as well, since vpc_create() did not set errp > in this failuer case. Set errp in all instances in vpc_create(). s/faileur/failure/ Can be done when merging, no need to resend. signature.asc Description: PGP signat

[Qemu-devel] [PATCH for-2.6 1/7] block/vpc: fix VPC 'qemu-img create' regression

2016-03-22 Thread Jeff Cody
Commit 'b8f45cdf7827e39f9a1e6cc446f5972cc6144237' switched VPC over to using blk_pwrite() instead of bdrv_pwrite_sync(). The return value of bdrv_pwrite_sync() was always 0 for success, and create_dynamic_disk() in one instance checked for a non-zero return value to indicate error. However, blk_p