Re: [Qemu-devel] [PATCH for-2.9? v4] ipmi: Fix macro issues

2017-03-31 Thread Ed Maste
On 31 March 2017 at 11:04, Eric Blake wrote: > > Might also be worth adding that an audit of the code finds no semantic > change, that this is just cleaning up the compiler warning. We should include core detail of your detailed analysis in such a statement I think, because I

Re: [Qemu-devel] [PATCH for-2.9? v4] ipmi: Fix macro issues

2017-03-31 Thread Corey Minyard
On 03/31/2017 10:04 AM, Eric Blake wrote: On 03/31/2017 09:33 AM, miny...@acm.org wrote: From: Corey Minyard Macro parameters should almost always have () around them when used. llvm reported an error on this. Remove redundant parenthesis and put parenthesis around the

Re: [Qemu-devel] [PATCH for-2.9? v4] ipmi: Fix macro issues

2017-03-31 Thread Eric Blake
On 03/31/2017 09:33 AM, miny...@acm.org wrote: > From: Corey Minyard > > Macro parameters should almost always have () around them when used. > llvm reported an error on this. > > Remove redundant parenthesis and put parenthesis around the entire > macros with assignments