Re: [Qemu-devel] [PATCH for-2.9 37/47] qapi: Fix detection of bogus member documentation

2017-03-15 Thread Markus Armbruster
Eric Blake writes: > On 03/13/2017 01:18 AM, Markus Armbruster wrote: >> check_definition_doc() checks for member documentation without a >> matching member. It laboriously second-guesses what members >> QAPISchema._def_exprs() will create. That's a stupid game. >> >> Move

Re: [Qemu-devel] [PATCH for-2.9 37/47] qapi: Fix detection of bogus member documentation

2017-03-14 Thread Eric Blake
On 03/13/2017 01:18 AM, Markus Armbruster wrote: > check_definition_doc() checks for member documentation without a > matching member. It laboriously second-guesses what members > QAPISchema._def_exprs() will create. That's a stupid game. > > Move the check into QAPISchema.check(), where the

[Qemu-devel] [PATCH for-2.9 37/47] qapi: Fix detection of bogus member documentation

2017-03-13 Thread Markus Armbruster
check_definition_doc() checks for member documentation without a matching member. It laboriously second-guesses what members QAPISchema._def_exprs() will create. That's a stupid game. Move the check into QAPISchema.check(), where the members are known. Delegate the actual checking to new