Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-11 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 10:07:31AM +0100, Daniel P. Berrangé wrote: > On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > > Every time we create new PC machine-types in QEMU, the defaults > > for SMBIOS fields change unnecessarily because the version field > > defaults to MachineClas

Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-10 Thread Daniel P . Berrangé
On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > Every time we create new PC machine-types in QEMU, the defaults > for SMBIOS fields change unnecessarily because the version field > defaults to MachineClass::name. > > This can cause unexpected side-effects, like triggering licens

Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-09 Thread Eduardo Habkost
On Tue, Jul 10, 2018 at 02:54:12AM +0300, Michael S. Tsirkin wrote: > On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > > Every time we create new PC machine-types in QEMU, the defaults > > for SMBIOS fields change unnecessarily because the version field > > defaults to MachineClas

Re: [Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-09 Thread Michael S. Tsirkin
On Mon, Jul 09, 2018 at 05:37:31PM -0300, Eduardo Habkost wrote: > Every time we create new PC machine-types in QEMU, the defaults > for SMBIOS fields change unnecessarily because the version field > defaults to MachineClass::name. > > This can cause unexpected side-effects, like triggering licens

[Qemu-devel] [PATCH for-3.0] pc: Use "3.0+" constant as default SMBIOS version

2018-07-09 Thread Eduardo Habkost
Every time we create new PC machine-types in QEMU, the defaults for SMBIOS fields change unnecessarily because the version field defaults to MachineClass::name. This can cause unexpected side-effects, like triggering license reactivation on guest software, or changing the VM memory layout because