Re: [Qemu-devel] [PATCH for-3.1 3/4] slirp: Remove code that handles socreate() failure

2018-11-06 Thread Samuel Thibault
Peter Maydell, le mar. 06 nov. 2018 15:13:22 +, a ecrit: > Now that socreate() can never fail, we can remove the code > that was trying to handle that situation. > > In particular this removes code in tcp_connect() that > provoked Coverity to complain (CID 1005724): in >

[Qemu-devel] [PATCH for-3.1 3/4] slirp: Remove code that handles socreate() failure

2018-11-06 Thread Peter Maydell
Now that socreate() can never fail, we can remove the code that was trying to handle that situation. In particular this removes code in tcp_connect() that provoked Coverity to complain (CID 1005724): in closesocket(accept(inso->s, (struct sockaddr *), )); if the accept() call fails then we pass