Re: [Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 12:25:15PM +0100, Greg Kurz wrote: > On Mon, 25 Mar 2019 17:38:49 +1100 > David Gibson wrote: > > > On Fri, Mar 22, 2019 at 07:03:46PM +0100, Greg Kurz wrote: > > > Even if all ISAs up to v3 indeed mention: > > > > > > If the "decrement and test CTR" option is specifi

Re: [Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-25 Thread David Gibson
On Mon, Mar 25, 2019 at 12:25:15PM +0100, Greg Kurz wrote: > On Mon, 25 Mar 2019 17:38:49 +1100 > David Gibson wrote: > > > On Fri, Mar 22, 2019 at 07:03:46PM +0100, Greg Kurz wrote: > > > Even if all ISAs up to v3 indeed mention: > > > > > > If the "decrement and test CTR" option is specifi

Re: [Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-25 Thread Greg Kurz
On Mon, 25 Mar 2019 17:38:49 +1100 David Gibson wrote: > On Fri, Mar 22, 2019 at 07:03:46PM +0100, Greg Kurz wrote: > > Even if all ISAs up to v3 indeed mention: > > > > If the "decrement and test CTR" option is specified (BO2=0), the > > instruction form is invalid. > > > > The UMs of

Re: [Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-24 Thread David Gibson
On Fri, Mar 22, 2019 at 07:03:46PM +0100, Greg Kurz wrote: > Even if all ISAs up to v3 indeed mention: > > If the "decrement and test CTR" option is specified (BO2=0), the > instruction form is invalid. > > The UMs of all existing 64-bit server class processors say: I've applied this ser

[Qemu-devel] [PATCH for-4.0 2/3] target/ppc: Enable "decrement and test CTR" version of bcctr

2019-03-22 Thread Greg Kurz
Even if all ISAs up to v3 indeed mention: If the "decrement and test CTR" option is specified (BO2=0), the instruction form is invalid. The UMs of all existing 64-bit server class processors say: If BO[2] = 0, the contents of CTR (before any update) are used as the target address