Re: [Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size

2019-01-07 Thread Li Zhijian
On 1/7/19 18:33, Stefano Garzarella wrote: On Mon, Dec 24, 2018 at 3:16 AM Li Zhijian wrote: On 12/22/18 00:12, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 10:32:11AM +0800, Li Zhijian wrote: Don't expect read(2) can always read as many as it's told. Signed-off-by: Li Zhijian

Re: [Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size

2019-01-07 Thread Stefano Garzarella
On Mon, Dec 24, 2018 at 3:16 AM Li Zhijian wrote: > > > On 12/22/18 00:12, Michael S. Tsirkin wrote: > > On Thu, Dec 06, 2018 at 10:32:11AM +0800, Li Zhijian wrote: > >> Don't expect read(2) can always read as many as it's told. > >> > >> Signed-off-by: Li Zhijian > >> Reviewed-by: Richard

Re: [Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size

2018-12-23 Thread Li Zhijian
On 12/22/18 00:12, Michael S. Tsirkin wrote: On Thu, Dec 06, 2018 at 10:32:11AM +0800, Li Zhijian wrote: Don't expect read(2) can always read as many as it's told. Signed-off-by: Li Zhijian Reviewed-by: Richard Henderson This is more a theoretical bugfix than a refactoring right? Yes,

Re: [Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size

2018-12-21 Thread Michael S. Tsirkin
On Thu, Dec 06, 2018 at 10:32:11AM +0800, Li Zhijian wrote: > Don't expect read(2) can always read as many as it's told. > > Signed-off-by: Li Zhijian > Reviewed-by: Richard Henderson This is more a theoretical bugfix than a refactoring right? > --- > V4: add reviewed-by tag > --- >

[Qemu-devel] [PATCH for-4.0 v4 2/4] refactor load_image_size

2018-12-05 Thread Li Zhijian
Don't expect read(2) can always read as many as it's told. Signed-off-by: Li Zhijian Reviewed-by: Richard Henderson --- V4: add reviewed-by tag --- hw/core/loader.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/core/loader.c b/hw/core/loader.c index