Re: [Qemu-devel] [PATCH for-4.1] linux-user: Make sigaltstack stacks per-thread

2019-07-26 Thread Peter Maydell
On Fri, 26 Jul 2019 at 18:17, Laurent Vivier wrote: > Tested-by: Laurent Vivier > Reviewed-by: Laurent Vivier > > This patch seems also to fix failure of LTP test waitpid02. Well, that's a bonus :-) Could you submit a pullreq in time for rc3 (Tuesday), please? thanks -- PMM

Re: [Qemu-devel] [PATCH for-4.1] linux-user: Make sigaltstack stacks per-thread

2019-07-26 Thread Laurent Vivier
Le 25/07/2019 à 15:16, Peter Maydell a écrit : > The alternate signal stack set up by the sigaltstack syscall is > supposed to be per-thread. We were incorrectly implementing it as > process-wide. This causes problems for guest binaries that rely on > this. Notably the Go runtime does, and so we

Re: [Qemu-devel] [PATCH for-4.1] linux-user: Make sigaltstack stacks per-thread

2019-07-25 Thread Richard Henderson
On 7/25/19 6:16 AM, Peter Maydell wrote: > The alternate signal stack set up by the sigaltstack syscall is > supposed to be per-thread. We were incorrectly implementing it as > process-wide. This causes problems for guest binaries that rely on > this. Notably the Go runtime does, and so we were

Re: [Qemu-devel] [PATCH for-4.1] linux-user: Make sigaltstack stacks per-thread

2019-07-25 Thread Laurent Vivier
Le 25/07/2019 à 15:16, Peter Maydell a écrit : > The alternate signal stack set up by the sigaltstack syscall is > supposed to be per-thread. We were incorrectly implementing it as > process-wide. This causes problems for guest binaries that rely on > this. Notably the Go runtime does, and so we

[Qemu-devel] [PATCH for-4.1] linux-user: Make sigaltstack stacks per-thread

2019-07-25 Thread Peter Maydell
The alternate signal stack set up by the sigaltstack syscall is supposed to be per-thread. We were incorrectly implementing it as process-wide. This causes problems for guest binaries that rely on this. Notably the Go runtime does, and so we were seeing crashes caused by races where two guest th