Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-05 Thread Michael S. Tsirkin
On Sun, Dec 04, 2011 at 04:47:17PM -0700, Cam Macdonell wrote: On Sun, Dec 4, 2011 at 3:20 AM, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 02, 2011 at 04:34:21PM -0700, Cam Macdonell wrote: Based on a git bisect, this patch breaks msi-x interrupt delivery in the ivshmem device.

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-05 Thread Cam Macdonell
On Mon, Dec 5, 2011 at 2:08 AM, Michael S. Tsirkin m...@redhat.com wrote: On Sun, Dec 04, 2011 at 04:47:17PM -0700, Cam Macdonell wrote: On Sun, Dec 4, 2011 at 3:20 AM, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 02, 2011 at 04:34:21PM -0700, Cam Macdonell wrote: Based on a git

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-04 Thread Michael S. Tsirkin
On Fri, Dec 02, 2011 at 04:34:21PM -0700, Cam Macdonell wrote: Based on a git bisect, this patch breaks msi-x interrupt delivery in the ivshmem device. On Mon, Nov 21, 2011 at 9:57 AM, Michael S. Tsirkin m...@redhat.com wrote: Only go over the table when function is masked. This is not

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-04 Thread Michael S. Tsirkin
On Fri, Dec 02, 2011 at 04:34:21PM -0700, Cam Macdonell wrote: Based on a git bisect, this patch breaks msi-x interrupt delivery in the ivshmem device. I think the following should fix it. Compiled-only - could you pls check? If yes let's apply to the stable branch. -- ivshmem: add missing

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-04 Thread Jan Kiszka
On 2011-12-04 11:20, Michael S. Tsirkin wrote: On Fri, Dec 02, 2011 at 04:34:21PM -0700, Cam Macdonell wrote: Based on a git bisect, this patch breaks msi-x interrupt delivery in the ivshmem device. I think the following should fix it. Compiled-only - could you pls check? If yes let's apply

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-04 Thread Michael S. Tsirkin
On Sun, Dec 04, 2011 at 01:35:03PM +0100, Jan Kiszka wrote: On 2011-12-04 11:20, Michael S. Tsirkin wrote: On Fri, Dec 02, 2011 at 04:34:21PM -0700, Cam Macdonell wrote: Based on a git bisect, this patch breaks msi-x interrupt delivery in the ivshmem device. I think the following

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-04 Thread Cam Macdonell
On Sun, Dec 4, 2011 at 3:20 AM, Michael S. Tsirkin m...@redhat.com wrote: On Fri, Dec 02, 2011 at 04:34:21PM -0700, Cam Macdonell wrote: Based on a git bisect, this patch breaks msi-x interrupt delivery in the ivshmem device. I think the following should fix it. Compiled-only - could you pls

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-03 Thread Jan Kiszka
On 2011-12-03 00:34, Cam Macdonell wrote: So I believe my bug is due to the fact the new logic included in this patch requires msix_write_config() to be called to unmask the vectors. Virtio-pci calls msix_write_config(), but ivshmem does not (nor does PCIe so I'm not sure if it's also

Re: [Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-12-02 Thread Cam Macdonell
Based on a git bisect, this patch breaks msi-x interrupt delivery in the ivshmem device. On Mon, Nov 21, 2011 at 9:57 AM, Michael S. Tsirkin m...@redhat.com wrote: Only go over the table when function is masked. This is not really important for qemu.git but helps fix a bug in qemu-kvm.git.

[Qemu-devel] [PATCH for v1.0 1/3] msix: track function masked in pci device state

2011-11-21 Thread Michael S. Tsirkin
Only go over the table when function is masked. This is not really important for qemu.git but helps fix a bug in qemu-kvm.git. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/msix.c | 21 ++--- hw/pci.h |2 ++ 2 files changed, 16 insertions(+), 7 deletions(-)