Re: [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.

2013-05-14 Thread Richard Henderson
On 05/13/2013 01:33 PM, Max Filippov wrote: memory access at points (1) and (2) can abort the instruction (it did so b/o the bug, but it may do so legitimately when you add MMU support), but it has modified REG(1) at those points, which will not be restored. It's probably worth carrying

[Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.

2013-05-13 Thread Anthony Green
Fix a simple bug in tlb_fill for moxie. The port was mostly working before, which is why I only really noticed it recently. Thanks to @jcmvbkbc for tracking it down. Signed-off-by: Anthony Green gr...@moxielogic.com --- target-moxie/helper.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Qemu-devel] [PATCH moxie] Fix bug in tlb_fill.

2013-05-13 Thread Max Filippov
On Tue, May 14, 2013 at 12:04 AM, Anthony Green gr...@moxielogic.com wrote: Fix a simple bug in tlb_fill for moxie. The port was mostly working before, which is why I only really noticed it recently. Thanks to @jcmvbkbc for tracking it down. Signed-off-by: Anthony Green gr...@moxielogic.com