Re: [Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

2017-03-28 Thread Jason Wang
On 2017年03月27日 12:40, Alexey Kardashevskiy wrote: The recent introduction of a bus master container added memory_region_add_subregion() into the PCI device registering path but missed memory_region_del_subregion() in the unregistering path leaving a reference to the root memory region of the

Re: [Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

2017-03-27 Thread David Gibson
On Tue, Mar 28, 2017 at 05:33:48AM +0300, Michael S. Tsirkin wrote: > On Tue, Mar 28, 2017 at 11:06:28AM +1100, David Gibson wrote: > > On Mon, Mar 27, 2017 at 05:28:17PM +0200, Paolo Bonzini wrote: > > > > > > > > > On 27/03/2017 06:40, Alexey Kardashevskiy wrote: > > > > The recent

Re: [Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

2017-03-27 Thread Michael S. Tsirkin
On Tue, Mar 28, 2017 at 11:06:28AM +1100, David Gibson wrote: > On Mon, Mar 27, 2017 at 05:28:17PM +0200, Paolo Bonzini wrote: > > > > > > On 27/03/2017 06:40, Alexey Kardashevskiy wrote: > > > The recent introduction of a bus master container added > > > memory_region_add_subregion() into the

Re: [Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

2017-03-27 Thread David Gibson
On Mon, Mar 27, 2017 at 05:28:17PM +0200, Paolo Bonzini wrote: > > > On 27/03/2017 06:40, Alexey Kardashevskiy wrote: > > The recent introduction of a bus master container added > > memory_region_add_subregion() into the PCI device registering path but > > missed memory_region_del_subregion() in

Re: [Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

2017-03-27 Thread Paolo Bonzini
On 27/03/2017 06:40, Alexey Kardashevskiy wrote: > The recent introduction of a bus master container added > memory_region_add_subregion() into the PCI device registering path but > missed memory_region_del_subregion() in the unregistering path leaving > a reference to the root memory region of

[Qemu-devel] [PATCH qemu] pci: Add missing drop of bus master AS reference

2017-03-26 Thread Alexey Kardashevskiy
The recent introduction of a bus master container added memory_region_add_subregion() into the PCI device registering path but missed memory_region_del_subregion() in the unregistering path leaving a reference to the root memory region of the new container. This adds missing