Re: [Qemu-devel] [PATCH qemu] target/ppc: Yet another fix for KVM-HV HPTE accessors

2018-01-11 Thread David Gibson
On Thu, Jan 11, 2018 at 08:06:13AM +, Mark Cave-Ayland wrote: > On 11/01/18 04:08, Alexey Kardashevskiy wrote: > > > As stated in the 1ad9f0a464fe commit log, the returned entries are not > > a while PTEG. It was not a problem before 1ad9f0a464fe as it would read > > s/while/whole/? I

Re: [Qemu-devel] [PATCH qemu] target/ppc: Yet another fix for KVM-HV HPTE accessors

2018-01-11 Thread Mark Cave-Ayland
On 11/01/18 04:08, Alexey Kardashevskiy wrote: As stated in the 1ad9f0a464fe commit log, the returned entries are not a while PTEG. It was not a problem before 1ad9f0a464fe as it would read s/while/whole/? a single record assuming it contains a whole PTEG but now the code tries reading the

Re: [Qemu-devel] [PATCH qemu] target/ppc: Yet another fix for KVM-HV HPTE accessors

2018-01-10 Thread David Gibson
On Thu, Jan 11, 2018 at 03:08:32PM +1100, Alexey Kardashevskiy wrote: > As stated in the 1ad9f0a464fe commit log, the returned entries are not > a while PTEG. It was not a problem before 1ad9f0a464fe as it would read > a single record assuming it contains a whole PTEG but now the code tries >

[Qemu-devel] [PATCH qemu] target/ppc: Yet another fix for KVM-HV HPTE accessors

2018-01-10 Thread Alexey Kardashevskiy
As stated in the 1ad9f0a464fe commit log, the returned entries are not a while PTEG. It was not a problem before 1ad9f0a464fe as it would read a single record assuming it contains a whole PTEG but now the code tries reading the entire PTEG and "if ((n - i) < invalid)" produces negative values