Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-05-02 Thread Paolo Bonzini
On 29/04/2017 14:36, Alexey Kardashevskiy wrote: >> Checking PATCH 1/1: memory/iommu: QOM'fy IOMMU MemoryRegion... >> ERROR: spaces required around that '*' (ctx:WxO) >> #156: FILE: hw/dma/rc4030.c:720: >> +DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion **dma_mr) > > What does

Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-30 Thread David Gibson
On Sun, Apr 30, 2017 at 09:11:04PM +0800, Fam Zheng wrote: > On Sat, 04/29 22:36, Alexey Kardashevskiy wrote: > > > === OUTPUT BEGIN === > > > Checking PATCH 1/1: memory/iommu: QOM'fy IOMMU MemoryRegion... > > > ERROR: spaces required around that '*' (ctx:WxO) > > > #156: FILE:

Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-30 Thread Fam Zheng
On Sat, 04/29 22:36, Alexey Kardashevskiy wrote: > > === OUTPUT BEGIN === > > Checking PATCH 1/1: memory/iommu: QOM'fy IOMMU MemoryRegion... > > ERROR: spaces required around that '*' (ctx:WxO) > > #156: FILE: hw/dma/rc4030.c:720: > > +DeviceState *rc4030_init(rc4030_dma **dmas, IOMMUMemoryRegion

Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread Alexey Kardashevskiy
On 29/04/17 22:28, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion > Message-id: 20170429115509.27551-1

Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion Message-id: 20170429115509.27551-1-...@ozlabs.ru Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

Re: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20170429115509.27551-1-...@ozlabs.ru Subject: [Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked

[Qemu-devel] [PATCH qemu v4] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-04-29 Thread Alexey Kardashevskiy
This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion as a parent. This moves IOMMU-related fields from MR to IOMMU MR. However to avoid dymanic QOM casting in fast path (address_space_translate, etc), this adds an @is_iommu boolean flag to MR and provides new helper to do simple