Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-31 Thread Jan Kiszka
On 2011-05-31 03:25, BrillyWu wrote: Hi, Jan patch which has been checked. It can be compiled without any error and work normally. The patch v3 is here now. The above text can't be used as a commit log, so this needs to be fixed. Moreover, your patch still contains at least on

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-31 Thread BrillyWu
Hi, Jan I am sure I have checked it with the scripts/checkpatch.pl, and it shows no error or warning. Maybe I should check whether my windows editor and mail client can work well before sending it to you. I 'm sorry. Sorry, you are right. Your patch revealed a bug in the checkpatch

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-31 Thread Jan Kiszka
On 2011-05-31 09:39, BrillyWu wrote: Hi, Jan I am sure I have checked it with the scripts/checkpatch.pl, and it shows no error or warning. Maybe I should check whether my windows editor and mail client can work well before sending it to you. I 'm sorry. Sorry, you are right. Your patch

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-31 Thread BrillyWu
Blue, this does not trigger the missing braces warning: Do you mean the bug is that it can not trigger missing braces warining? The script fails to detect missing braces as marked below. It seems that there is no missing braces in my patch, but some unnecessary braces. There are no

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread BrillyWu
From: BrillyWu brill...@viatech.com.cn Hi, Jan I'm very sorry for these bugs in the patch. Now I have made a new patch based on the newest uq/master where the patch has been applied to fix these bugs, is it feasible? If it is not acceptable, should I re-generate a patch based on previous

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread Jan Kiszka
On 2011-05-30 09:40, BrillyWu wrote: From: BrillyWu brill...@viatech.com.cn Hi, Jan I'm very sorry for these bugs in the patch. Now I have made a new patch based on the newest uq/master where the patch has been applied to fix these bugs, is it feasible? If it is not acceptable,

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread BrillyWu
From brill...@viatech.com.cn Hi, Jan Thank you for you review and guide. I have fixed the bugs and re-generated a clean patch which has been checked. It can be compiled without any error and work normally. The patch v3 is here now. Signed-off-by:

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread Jan Kiszka
On 2011-05-30 10:59, BrillyWu wrote: From brill...@viatech.com.cn Hi, Jan Thank you for you review and guide. I have fixed the bugs and re-generated a clean patch which has been checked. It can be compiled without any error and work normally. The patch v3 is here

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-30 Thread BrillyWu
Hi, Jan patch which has been checked. It can be compiled without any error and work normally. The patch v3 is here now. The above text can't be used as a commit log, so this needs to be fixed. Moreover, your patch still contains at least on style issues scripts/checkpatch.pl

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-29 Thread BrillyWu
Hi, Jan @@ -855,6 +870,8 @@ int cpu_x86_register (CPUX86State *env, env-cpuid_xlevel = def-xlevel; env-cpuid_kvm_features = def-kvm_features; env-cpuid_svm_features = def-svm_features; +env-cpuid_ext4_features = def-ext4_features; +env-cpuid_xlevel2 =

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-28 Thread Jan Kiszka
On 2011-05-10 10:02, BrillyWu wrote: From: BrillyWu brill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWubrill...@viatech.com.cn

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-28 Thread Jan Kiszka
On 2011-05-10 10:02, BrillyWu wrote: From: BrillyWu brill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWubrill...@viatech.com.cn

Re: [Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-11 Thread Avi Kivity
On 05/10/2011 11:02 AM, BrillyWu wrote: From: BrillyWubrill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Applied, thanks. -- error compiling committee.c: too many

[Qemu-devel] [PATCH uq/master V2] kvm: Add CPUID support for VIA CPU

2011-05-10 Thread BrillyWu
From: BrillyWu brill...@viatech.com.cn When KVM is running on VIA CPU with host cpu's model, the feautures of VIA CPU will be passed into kvm guest by calling the CPUID instruction for Centaur. Signed-off-by: BrillyWubrill...@viatech.com.cn Signed-off-by: KaryJinkary...@viatech.com.cn ---