Re: [Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread David Hildenbrand
> atomic_mb_set can be a little faster on x86, so: > > diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c > index dfba5ebd29..4452cd9856 100644 > --- a/accel/tcg/cpu-exec.c > +++ b/accel/tcg/cpu-exec.c > @@ -528,12 +528,10 @@ static inline bool cpu_handle_interrupt(CPUState *cpu, > >

Re: [Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

2017-12-11 Thread Paolo Bonzini
On 29/11/2017 20:13, David Hildenbrand wrote: > The conditional memory barrier not only looks strange but actually is > wrong. > > On s390x, I can reproduce interrupts via cpu_interrupt() not leading to > a proper kick out of emulation every now and then. cpu_interrupt() is > especially used for

[Qemu-devel] [PATCH v1] cpu-exec: fix missed CPU kick during interrupt injection

2017-11-29 Thread David Hildenbrand
The conditional memory barrier not only looks strange but actually is wrong. On s390x, I can reproduce interrupts via cpu_interrupt() not leading to a proper kick out of emulation every now and then. cpu_interrupt() is especially used for inter CPU communication via SIGP (esp. external calls and