Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-08-02 Thread Cornelia Huck
On Wed, 25 Jul 2018 11:12:33 +0200 David Hildenbrand wrote: > The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like > a CPU with the maximum possible feature set when TCG is enabled. > > While the "host" model can not be used under TCG ("kvm_required"), the > "max" model can

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-27 Thread Cornelia Huck
On Wed, 25 Jul 2018 11:12:33 +0200 David Hildenbrand wrote: > The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like > a CPU with the maximum possible feature set when TCG is enabled. > > While the "host" model can not be used under TCG ("kvm_required"), the > "max" model can

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-26 Thread Eduardo Habkost
On Thu, Jul 26, 2018 at 09:29:44AM +0200, David Hildenbrand wrote: > On 25.07.2018 22:14, Eduardo Habkost wrote: > > On Wed, Jul 25, 2018 at 07:50:21PM +0200, David Hildenbrand wrote: > >> On 25.07.2018 19:09, Eduardo Habkost wrote: > > [...] > +if (local_err) { > +g_assert(kv

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-26 Thread David Hildenbrand
On 25.07.2018 22:14, Eduardo Habkost wrote: > On Wed, Jul 25, 2018 at 07:50:21PM +0200, David Hildenbrand wrote: >> On 25.07.2018 19:09, Eduardo Habkost wrote: > [...] +if (local_err) { +g_assert(kvm_enabled()); +error_report_err(local_err); +/* fallb

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread Eduardo Habkost
On Wed, Jul 25, 2018 at 07:50:21PM +0200, David Hildenbrand wrote: > On 25.07.2018 19:09, Eduardo Habkost wrote: [...] > >> +if (local_err) { > >> +g_assert(kvm_enabled()); > >> +error_report_err(local_err); > >> +/* fallback to unsupported CPU models */ > >> +re

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread David Hildenbrand
On 25.07.2018 19:09, Eduardo Habkost wrote: > On Wed, Jul 25, 2018 at 11:12:33AM +0200, David Hildenbrand wrote: >> The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like >> a CPU with the maximum possible feature set when TCG is enabled. >> >> While the "host" model can not be

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread Eduardo Habkost
On Wed, Jul 25, 2018 at 11:12:33AM +0200, David Hildenbrand wrote: > The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like > a CPU with the maximum possible feature set when TCG is enabled. > > While the "host" model can not be used under TCG ("kvm_required"), the > "max" mode

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread Cornelia Huck
On Wed, 25 Jul 2018 14:49:45 +0200 David Hildenbrand wrote: > >> > >>> Maybe add a comment that for kvm we try the host model, and only that > >>> can fail (i.e., for tcg this will always work)? > >> > >> "we expect only errors under KVM, when we actually query the kernel" > > > > "We ex

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread David Hildenbrand
>> >>> Maybe add a comment that for kvm we try the host model, and only that >>> can fail (i.e., for tcg this will always work)? >> >> "we expect only errors under KVM, when we actually query the kernel" > > "We expect errors only under KVM, where we actually query the kernel" > > ? Sure, mayb

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread Cornelia Huck
On Wed, 25 Jul 2018 13:58:16 +0200 David Hildenbrand wrote: > On 25.07.2018 13:36, Cornelia Huck wrote: > > On Wed, 25 Jul 2018 11:12:33 +0200 > > David Hildenbrand wrote: > > > >> The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like > >> a CPU with the maximum possible

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread David Hildenbrand
On 25.07.2018 13:36, Cornelia Huck wrote: > On Wed, 25 Jul 2018 11:12:33 +0200 > David Hildenbrand wrote: > >> The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like >> a CPU with the maximum possible feature set when TCG is enabled. >> >> While the "host" model can not be use

Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread Cornelia Huck
On Wed, 25 Jul 2018 11:12:33 +0200 David Hildenbrand wrote: > The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like > a CPU with the maximum possible feature set when TCG is enabled. > > While the "host" model can not be used under TCG ("kvm_required"), the > "max" model can

[Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support

2018-07-25 Thread David Hildenbrand
The "max" CPU model behaves like "-cpu host" when KVM is enabled, and like a CPU with the maximum possible feature set when TCG is enabled. While the "host" model can not be used under TCG ("kvm_required"), the "max" model can and "Enables all features supported by the accelerator in the current h