On 09/22/2017 08:18 AM, David Hildenbrand wrote:
> On 22.09.2017 15:12, Richard Henderson wrote:
>> I don't believe you need to use QEMU_PACKED. Unless the "addr" that's passed
>> in can really be arbitrary? (If so, the memory returned by
>> cpu_physical_memory_map will be unaligned and so we do
On 09/21/2017 11:30 PM, David Hildenbrand wrote:
> env->psa is a 64bit value, while we copy 4 bytes into the save area,
> resulting always in 0 getting stored.
>
> Let's try to reduce such errors by using a proper structure. While at
> it, use correct cpu->be conversion (and get_psw_mask()), as
On 22.09.2017 15:12, Richard Henderson wrote:
> On 09/21/2017 04:30 PM, David Hildenbrand wrote:
>> +struct sigp_save_area {
>> +uint64_tfprs[16]; /* 0x */
>> +uint64_tgrs[16];/* 0x0080 */
>> +PSW psw;
On 09/21/2017 04:30 PM, David Hildenbrand wrote:
> +struct sigp_save_area {
> +uint64_tfprs[16]; /* 0x */
> +uint64_tgrs[16];/* 0x0080 */
> +PSW psw;/* 0x0100 */
> +uint8_t
env->psa is a 64bit value, while we copy 4 bytes into the save area,
resulting always in 0 getting stored.
Let's try to reduce such errors by using a proper structure. While at
it, use correct cpu->be conversion (and get_psw_mask()), as we will be
reusing this code for TCG soon.
Signed-off-by:
