Re: [Qemu-devel] [PATCH v1] s390x/tcg: add various alignment check

On 14.02.2018 17:05, Richard Henderson wrote: > On 02/14/2018 07:25 AM, David Hildenbrand wrote: >> /* SET CLOCK COMPARATOR */ >> -C(0xb206, SCKC,S, Z, 0, m2_64, 0, 0, sckc, 0) >> +C(0xb206, SCKC,S, Z, 0, a2, 0, 0, sckc, 0) > > Rather than move the memory load into

Re: [Qemu-devel] [PATCH v1] s390x/tcg: add various alignment check

On 02/14/2018 07:25 AM, David Hildenbrand wrote: > /* SET CLOCK COMPARATOR */ > -C(0xb206, SCKC,S, Z, 0, m2_64, 0, 0, sckc, 0) > +C(0xb206, SCKC,S, Z, 0, a2, 0, 0, sckc, 0) Rather than move the memory load into the op_ functions, better to add an m2_64a (etc)

[Qemu-devel] [PATCH v1] s390x/tcg: add various alignment check

Let's add proper alignment checks for a handful of instructions that require a SPECIFICATION exception in case alignment is violated. Signed-off-by: David Hildenbrand --- With this, all upstream kvm-unit-tests pass under TCG. target/s390x/insn-data.def | 14 +++---