Re: [Qemu-devel] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-01 Thread Richard Henderson
On 03/02/2017 02:24 AM, Nikunj A Dadhania wrote: +static void float64_madd_set_vxisi(CPUPPCState *env, float64 a, float64 b, + float64 c, unsigned int flags) { +float64 f = float64_mul(a, b, &env->fp_status); What is the point of this multiply? +/* a

Re: [Qemu-devel] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-01 Thread Richard Henderson
On 03/02/2017 11:29 AM, David Gibson wrote: On Wed, Mar 01, 2017 at 08:54:14PM +0530, Nikunj A Dadhania wrote: Use the softfloat api for fused multiply-add. Also, generate VXISI using a helper function by computing intermediate result. Um.. I really need some information on why this is a good

Re: [Qemu-devel] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-01 Thread David Gibson
On Wed, Mar 01, 2017 at 08:54:14PM +0530, Nikunj A Dadhania wrote: > Use the softfloat api for fused multiply-add. Also, generate VXISI using > a helper function by computing intermediate result. Um.. I really need some information on why this is a good thing to do. Is it a bugfix? Enhancement?

[Qemu-devel] [PATCH v1] target/ppc: rewrite f[n]m[add, sub] using float64_muladd

2017-03-01 Thread Nikunj A Dadhania
Use the softfloat api for fused multiply-add. Also, generate VXISI using a helper function by computing intermediate result. Signed-off-by: Nikunj A Dadhania --- v0: * Use MADD/MSUB_FLAGS as used by VSX instructions * Introduce helper float64_madd_set_vxisi() --- target/ppc/fpu_helper.c | 218